4483
0%
main: 93%

Ran 14 Apr 2015 03:03AM UTC

Jobs 10

Files 319

Run time 20min

Badge

Embed ▾

pending completion

Build # 4483

Build Type

push

travis-ci

Committed by

dturner-tw

Commit Message

Classpath isolation: make ivy resolution locally accurate.

In the global compilation strategy, the 'compile_classpath' product
contains a list of artifacts for each target.  This list need not be
accurate per-target so long as the total set of artifacts required for
the build is included somewhere in the product.  In ivy resolution, a
target T might request library L, version 1.0.  If some other target U
in the build brings in L 2.0, Ivy might not resolve L 1.0's
dependencies.  So, prior to this patch, the compile_classpath for T
would show L, but not L's dependencies.

In the isolated compilation strategy, compile_classpath must be
accurate per-target, since targets will be built independently.  So
if T were missing L's dependencies, T might not be buildable.

This patch solves this problem by ignoring version numbers when
retrieving dependencies, so that the resolved version can replace
the requested version in all cases.

Note that ivy resolution is still not 100% isolated; if T is built in
the same compile as U, it will be built against L 2.0, while if it is
built alone, it will be built against L 1.0.

Testing Done:
CI green: https://travis-ci.org/pantsbuild/pants/builds/58371122

Reviewed at https://rbcommons.com/s/twitter/r/2064/

Coverage Stats

12897 of 18668 relevant lines covered (69.09%)

0.69 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4483.1 (CI_FLAGS="-cjlpnet 'Various pants self checks'")	14 Apr 2015 03:04AM UTC		Travis Job 4483.1
2	4483.2 (CI_FLAGS="-fkmsrcjlpn 'Test examples and testprojects'")	14 Apr 2015 03:03AM UTC		Travis Job 4483.2
3	4483.3 (CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'")	14 Apr 2015 03:05AM UTC	69.09	Travis Job 4483.3
4	4483.4 (CI_FLAGS="-fkmsrcjlpet 'Python contrib tests'")	14 Apr 2015 03:05AM UTC		Travis Job 4483.4
5	4483.5 (CI_FLAGS="-fkmsrjlpnet -i 6:0 'Python integration tests for pants - shard 1'")	14 Apr 2015 03:11AM UTC		Travis Job 4483.5
6	4483.6 (CI_FLAGS="-fkmsrjlpnet -i 6:1 'Python integration tests for pants - shard 2'")	14 Apr 2015 03:13AM UTC		Travis Job 4483.6
7	4483.7 (CI_FLAGS="-fkmsrjlpnet -i 6:2 'Python integration tests for pants - shard 3'")	14 Apr 2015 03:14AM UTC		Travis Job 4483.7
8	4483.8 (CI_FLAGS="-fkmsrjlpnet -i 6:3 'Python integration tests for pants - shard 4'")	14 Apr 2015 03:12AM UTC		Travis Job 4483.8
9	4483.9 (CI_FLAGS="-fkmsrjlpnet -i 6:4 'Python integration tests for pants - shard 5'")	14 Apr 2015 03:19AM UTC		Travis Job 4483.9
10	4483.10 (CI_FLAGS="-fkmsrjlpnet -i 6:5 'Python integration tests for pants - shard 6'")	14 Apr 2015 03:24AM UTC		Travis Job 4483.10

Source Files on build 4483

Detailed source file information is not available for this build.

pantsbuild / pants / 4483
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4483

pantsbuild / pants / 4483 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4483

pantsbuild / pants / 4483
0%
main: 93%

README BADGES
x