3
0%
main: 93%

Ran 11 Apr 2015 06:49PM UTC

Files 317

Run time 19s

Badge

Embed ▾

Committed 11 Apr 2015 06:27PM UTC coverage: 69.054% (-0.04%) from 69.095%

Job # CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'"

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Fix issue with isolated strategy and sources owned by multiple targets

* Test all strategies in more cases.
* Execute multiple iterations of compilation to catch bugs related to registration of targets that are already 'valid'
* Add testproject and reproduction for an error in the "sources-with-multiple-owners" case for isolation.
* Split sources by context in compute_classes_by_source case.

This fixes an error we noticed while testing the isolated strategy where sources owned by multiple targets (yea, it's gross, I know) would end up with distinct classfiles for each target. This would cause `classes_by_source` to be ambiguous.

I know we've had performance issues with this code before, but in this case I feel confident that we haven't introduced any additional analysis parsing.

Testing Done:
https://github.com/pantsbuild/pants/pull/1400

Reviewed at https://rbcommons.com/s/twitter/r/2061/

Coverage Stats

12844 of 18600 relevant lines covered (69.05%)

0.69 hits per line

pantsbuild / pants / 4430 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4430.3 (CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'")

pantsbuild / pants / 4430 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4430.3 (CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'")

pantsbuild / pants / 4430 / 3
0%
main: 93%

README BADGES
x