4430
0%
main: 93%

Ran 11 Apr 2015 06:44PM UTC

Jobs 10

Files 317

Run time 22min

Badge

Embed ▾

pending completion

Build # 4430

Build Type

push

travis-ci

Committed by

stuhood

Commit Message

Fix issue with isolated strategy and sources owned by multiple targets

* Test all strategies in more cases.
* Execute multiple iterations of compilation to catch bugs related to registration of targets that are already 'valid'
* Add testproject and reproduction for an error in the "sources-with-multiple-owners" case for isolation.
* Split sources by context in compute_classes_by_source case.

This fixes an error we noticed while testing the isolated strategy where sources owned by multiple targets (yea, it's gross, I know) would end up with distinct classfiles for each target. This would cause `classes_by_source` to be ambiguous.

I know we've had performance issues with this code before, but in this case I feel confident that we haven't introduced any additional analysis parsing.

Testing Done:
https://github.com/pantsbuild/pants/pull/1400

Reviewed at https://rbcommons.com/s/twitter/r/2061/

Coverage Stats

30 of 30 new or added lines in 4 files covered. (100.0%)

12844 of 18600 relevant lines covered (69.05%)

0.69 hits per line

Uncovered Changes

Lines	Coverage	File
13	100.0	src/python/pants/backend/jvm/tasks/jvm_compile/jvm_compile_global_strategy.py
7	100.0	src/python/pants/backend/jvm/tasks/jvm_compile/jvm_compile_strategy.py
3	100.0	src/python/pants/backend/jvm/tasks/jvm_compile/jvm_compile_isolated_strategy.py
2	100.0	src/python/pants/backend/jvm/tasks/jvm_compile/jvm_compile.py

Coverage Regressions

Lines	Coverage	File
19	100.0	src/python/pants/backend/project_info/register.py
18	100.0	src/python/pants/backend/codegen/tasks/wire_gen.py
11	100.0	src/python/pants/base/run_info.py
1	100.0	src/python/pants/goal/context.py
1	100.0	src/python/pants/util/dirutil.py
1	100.0	src/python/pants/java/jar/manifest.py
1	100.0	src/python/pants/base/build_graph.py
1	100.0	src/python/pants/backend/python/python_chroot.py
1	100.0	src/python/pants/backend/jvm/tasks/jvm_compile/jvm_compile_global_strategy.py

Jobs

ID	Job ID	Ran	Coverage
1	4430.1 (CI_FLAGS="-cjlpnet 'Various pants self checks'")	11 Apr 2015 06:47PM UTC		Travis Job 4430.1
2	4430.2 (CI_FLAGS="-fkmsrcjlpn 'Test examples and testprojects'")	11 Apr 2015 06:44PM UTC		Travis Job 4430.2
3	4430.3 (CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'")	11 Apr 2015 06:49PM UTC	69.05	Travis Job 4430.3
4	4430.4 (CI_FLAGS="-fkmsrcjlpet 'Python contrib tests'")	11 Apr 2015 06:47PM UTC		Travis Job 4430.4
5	4430.5 (CI_FLAGS="-fkmsrjlpnet -i 6:0 'Python integration tests for pants - shard 1'")	11 Apr 2015 06:51PM UTC		Travis Job 4430.5
6	4430.6 (CI_FLAGS="-fkmsrjlpnet -i 6:1 'Python integration tests for pants - shard 2'")	11 Apr 2015 06:55PM UTC		Travis Job 4430.6
7	4430.7 (CI_FLAGS="-fkmsrjlpnet -i 6:2 'Python integration tests for pants - shard 3'")	11 Apr 2015 06:57PM UTC		Travis Job 4430.7
8	4430.8 (CI_FLAGS="-fkmsrjlpnet -i 6:3 'Python integration tests for pants - shard 4'")	11 Apr 2015 06:56PM UTC		Travis Job 4430.8
9	4430.9 (CI_FLAGS="-fkmsrjlpnet -i 6:4 'Python integration tests for pants - shard 5'")	11 Apr 2015 06:58PM UTC		Travis Job 4430.9
10	4430.10 (CI_FLAGS="-fkmsrjlpnet -i 6:5 'Python integration tests for pants - shard 6'")	11 Apr 2015 07:07PM UTC		Travis Job 4430.10

Source Files on build 4430

Detailed source file information is not available for this build.

pantsbuild / pants / 4430
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Changes

Coverage Regressions

Jobs

Source Files on build 4430

pantsbuild / pants / 4430 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Changes

Coverage Regressions

Jobs

Source Files on build 4430

pantsbuild / pants / 4430
0%
main: 93%

README BADGES
x