3
0%
main: 93%

Ran 07 Apr 2015 04:57PM UTC

Files 319

Run time 17s

Badge

Embed ▾

Committed 07 Apr 2015 04:39PM UTC coverage: 69.651% (-0.03%) from 69.683%

Job # CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'"

Build Type

push

travis-ci

Committed by

Commit Message

Change subproc sigint handler to exit more cleanly

The very fast exit of os._exit can cause the stdlib multiproc glue code in the parent process, specifically the queues readers that shuttle results between processes, to deadlock.

It appears that using `sys.exit` in subprocesses instead allows those queues to close in a way that does not cause the parent process to deadlock, while still ensuring that subprocesses exit.

As a refresher: Even if the work function passed to subprocs catches KeyboardInterrupt, the multiprocessing queue code still throws, so a signal handler of some kind is needed to prevent $numproc stacktraces being printed on interrupt.

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/56935938

Reviewed at https://rbcommons.com/s/twitter/r/2024/

Coverage Stats

12960 of 18607 relevant lines covered (69.65%)

0.7 hits per line

pantsbuild / pants / 4367 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4367.3 (CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'")

pantsbuild / pants / 4367 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4367.3 (CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'")

pantsbuild / pants / 4367 / 3
0%
main: 93%

README BADGES
x