3
0%
main: 93%

Ran 16 Mar 2015 05:54AM UTC

Files 316

Run time 1min

Badge

Embed ▾

Committed 16 Mar 2015 05:36AM UTC coverage: 68.778%. Remained the same

Job # CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'"

Build Type

push

travis-ci

Committed by

baroquebobcat

Commit Message

Fix regression in synthetic target context handling.

This fixes an issue I ran into testing the changes I introduced on Friday. The problem was that if you set derived_from to None, when applying the synthetic targets by their derived targets, the derived target would be None, so it would raise an error on the logging line I added. I removed the log line, since after thinking about it, I don't think it's necessary. Also I guarded adding targets to the synthetic target dict because if derived_from _is_ None, then it won't be used, so there's no point in adding it.

Testing Done:
added regression tests, ran them. Ran against command I was testing with and saw it succeed. CI baking here: https://travis-ci.org/pantsbuild/pants/builds/54474855

Reviewed at https://rbcommons.com/s/twitter/r/1921/

Coverage Stats

12594 of 18311 relevant lines covered (68.78%)

0.69 hits per line

pantsbuild / pants / 4051 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4051.3 (CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'")

pantsbuild / pants / 4051 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4051.3 (CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'")

pantsbuild / pants / 4051 / 3
0%
main: 93%

README BADGES
x