4051
0%
main: 93%

Ran 16 Mar 2015 05:51AM UTC

Jobs 10

Files 316

Run time 9min

Badge

Embed ▾

pending completion

Build # 4051

Build Type

push

travis-ci

Committed by

baroquebobcat

Commit Message

Fix regression in synthetic target context handling.

This fixes an issue I ran into testing the changes I introduced on Friday. The problem was that if you set derived_from to None, when applying the synthetic targets by their derived targets, the derived target would be None, so it would raise an error on the logging line I added. I removed the log line, since after thinking about it, I don't think it's necessary. Also I guarded adding targets to the synthetic target dict because if derived_from _is_ None, then it won't be used, so there's no point in adding it.

Testing Done:
added regression tests, ran them. Ran against command I was testing with and saw it succeed. CI baking here: https://travis-ci.org/pantsbuild/pants/builds/54474855

Reviewed at https://rbcommons.com/s/twitter/r/1921/

Coverage Stats

12594 of 18311 relevant lines covered (68.78%)

0.69 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4051.1 (CI_FLAGS="-clpnet 'Various pants self checks'")	16 Mar 2015 05:54AM UTC		Travis Job 4051.1
2	4051.2 (CI_FLAGS="-fkmsrclpn 'Test examples and testprojects'")	16 Mar 2015 05:52AM UTC		Travis Job 4051.2
3	4051.3 (CI_FLAGS="-fkmsrcnet 'Python unit tests for pants and pants-plugins'")	16 Mar 2015 05:54AM UTC	68.78	Travis Job 4051.3
4	4051.4 (CI_FLAGS="-fkmsrclpet 'Python contrib tests'")	16 Mar 2015 05:51AM UTC		Travis Job 4051.4
5	4051.5 (CI_FLAGS="-fkmsrlpnet -i 6:0 'Python integration tests for pants - shard 1'")	16 Mar 2015 05:53AM UTC		Travis Job 4051.5
6	4051.6 (CI_FLAGS="-fkmsrlpnet -i 6:1 'Python integration tests for pants - shard 2'")	16 Mar 2015 05:59AM UTC		Travis Job 4051.6
7	4051.7 (CI_FLAGS="-fkmsrlpnet -i 6:2 'Python integration tests for pants - shard 3'")	16 Mar 2015 05:58AM UTC		Travis Job 4051.7
8	4051.8 (CI_FLAGS="-fkmsrlpnet -i 6:3 'Python integration tests for pants - shard 4'")	16 Mar 2015 05:59AM UTC		Travis Job 4051.8
9	4051.9 (CI_FLAGS="-fkmsrlpnet -i 6:4 'Python integration tests for pants - shard 5'")	16 Mar 2015 06:00AM UTC		Travis Job 4051.9
10	4051.10 (CI_FLAGS="-fkmsrlpnet -i 6:5 'Python integration tests for pants - shard 6'")	16 Mar 2015 05:59AM UTC		Travis Job 4051.10

Source Files on build 4051

Detailed source file information is not available for this build.

pantsbuild / pants / 4051
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4051

pantsbuild / pants / 4051 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4051

pantsbuild / pants / 4051
0%
main: 93%

README BADGES
x