activeadmin
/
activeadmin
/
3903
/
6
59%
master: 79%
master: 79%
|
Ran
|
Files
156
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 57.906%. First build
travis-ci
Ryan Dlugosz
Add parens to method calls used as arg defaults, fix #3733 Ruby 2.2 included a [bug fix](https://bugs.ruby-lang.org/issues/9593) that impacts methods which call other methods as defaults for some of their arguments, e.g., `def bar(foo=foo)`. The fix is to include parenthesis on the method call, `def bar(foo=foo())`. A similar patch was [recently made](https://github.com/rails/rails/commit/e88da370f) to Rails to support Ruby 2.2. I only found two instances of method calls that used the problematic syntax. Failing tests revealed these methods; the following regex did not find other instances: `def.+\((\S+)\s*=\s*\1\)`. Additionally, because test-unit is not included with Ruby 2.2 (and is required for ActiveSupport 3.2.x), it has been explicitly included in the Gemfile in the Rails 3.1|2 section. Tests pass. The JSLint test was not executed because I did not have a JRE set up; I don't think this test is relevant to the issue at hand. Include Ruby 2.2.0 in Travis config Add test-unit for Rails 3.0 builds also
1974 of 3409 relevant lines covered (57.91%)
2.73 hits per line
