activeadmin
/
activeadmin
/
3903
59%
master: 79%
master: 79%
|
Ran
|
Jobs
5
|
Files
210
|
Run time
11min
|
Badge
Embed ▾
README BADGES
|
travis-ci
Ryan Dlugosz
Add parens to method calls used as arg defaults, fix #3733 Ruby 2.2 included a [bug fix](https://bugs.ruby-lang.org/issues/9593) that impacts methods which call other methods as defaults for some of their arguments, e.g., `def bar(foo=foo)`. The fix is to include parenthesis on the method call, `def bar(foo=foo())`. A similar patch was [recently made](https://github.com/rails/rails/commit/e88da370f) to Rails to support Ruby 2.2. I only found two instances of method calls that used the problematic syntax. Failing tests revealed these methods; the following regex did not find other instances: `def.+\((\S+)\s*=\s*\1\)`. Additionally, because test-unit is not included with Ruby 2.2 (and is required for ActiveSupport 3.2.x), it has been explicitly included in the Gemfile in the Rails 3.1|2 section. Tests pass. The JSLint test was not executed because I did not have a JRE set up; I don't think this test is relevant to the issue at hand. Include Ruby 2.2.0 in Travis config Add test-unit for Rails 3.0 builds also
2232 of 3666 relevant lines covered (60.88%)
12.83 hits per line
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 3903.1 (1.9.3, RAILS=3.0.20) | 156 |
58.48 |
Travis Job 3903.1 | |
| 2 | 3903.2 (1.9.3, RAILS=3.1.12) | 156 |
58.52 |
Travis Job 3903.2 | |
| 3 | 3903.3 (1.9.3, RAILS=3.2.14) | 156 |
57.94 |
Travis Job 3903.3 | |
| 5 | 3903.5 (2.2.0, RAILS=3.1.12) | 156 |
58.49 |
Travis Job 3903.5 | |
| 6 | 3903.6 (2.2.0, RAILS=3.2.14) | 156 |
57.91 |
Travis Job 3903.6 |
Source Files on build 3903
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|