activeadmin / activeadmin

81%

LAST BUILD ON BRANCH master

branch: master

CHANGE BRANCH

x

• show all
• master
• remove_minitest_have_tag
• root_to_helper_name
• 2595-permit-default-params
• test-more-rubies
• router_refactoring
• remove_metasearch_backports
• gitignore
• activeadmin_info
• base_filter_support_for_custom_ransackers
• iso_nb
• csv_byte_order_mark
• i18n_cleanup
• datepicker_css
• refector_attributes_table
• inherited_resources_1_5
• dont-stream-csv-in-development
• setting_with_questionmark
• 3539_fix_respond_to_all
• object_mapper_rename
• remove_dashboard_view
• remove_iconic
• remove_images
• 3560_fix_inputs_with_class
• 1903_inline_delete_comments
• todo_double_let_namespace
• refactor_download_format_links_helper
• 3197_csv_view_context
• 3406_pundit_method_missing
• 2734_form_css
• yard
• namespace_store
• i18n_spec
• js_initializers
• remove_js_aa
• simplify_devise_config
• travis_with_appraisal
• remove_kaminari_theme
• test_cucumber
• rails-4-2
• travistest
• use-inherited_resources-master
• use-inherited_resources-rails-4-2-branch
• 0-6-stable
• travis-0
• aa-0-6-ruby-2-2-fix
• v0.6.4
• fix_batch_action_context
• 3503_batch_action_context
• inherited_resources-1-6
• 2715-backport-fix
• travis-matrix
• v0.6.6
• timoschilling-patch-1
• refactor_errors
• v1.0.0.pre1
• 3874-except_hidden_fields
• test-rbx-with-travis
• truncate_display_name_methods
• test-rbx-with-travis-2
• timoschilling-execjs
• 3838-column_for_attribute-deprecation
• use-latest-rails-as-default
• fix-rails-3-2-ruby-2-2-test
• fix-32-22
• fix-32-22-2
• 3978-refactored
• 4039-max_per_page-config
• 4074-data-access-apply-order
• 3923-rework-comments-order
• fix-travis
• v1.0.0.pre2
• timoschilling-travis-email
• revert-4146-lock-shoulda-matchers
• rails-5
• keep-whole-changelog
• code-of-conduct
• csv-pagination
• rails3-ruby2
• bugfix/turbolinks
• rails-4-0-and-4-1
• rails5-test-ransack
• rails5-test-sass-rails
• fix-ruby-1-9
• revert-4426-4424-fix-new-with-cast
• timoschilling-method_or_proc_helper

Build # 4536

Build Type

Pull #3930

travis-ci

Committed by seanlinsley

Commit Message

use `columns_hash` to get around deprecation warning

we couldn’t use `type_for_column` since:
- it’s not intended as a public method and
- it would return a null object if the column had the default value (nil)

for example:
```
expected: "No"
     got: ""

(compared using ==)
 (RSpec::Expectations::ExpectationNotMetError)
./features/step_definitions/table_steps.rb:96:in `assert_cells_match'
./features/step_definitions/table_steps.rb:79:in `block (2 levels) in assert_tables_match'
./features/step_definitions/table_steps.rb:75:in `each_index'
./features/step_definitions/table_steps.rb:75:in `block in assert_tables_match'
./features/step_definitions/table_steps.rb:74:in `each_index'
./features/step_definitions/table_steps.rb:74:in `assert_tables_match'
./features/step_definitions/table_steps.rb:115:in `/^I should see the "([^"]*)" table:$/'
features/index/index_as_table.feature:252:in `Then I should see the "index_table_posts" table:'

Failing Scenarios:
cucumber features/index/index_as_table.feature:244 # Scenario: Sorting
```

Pull Request Pull Request #3930: Fix the column_for_attribute deprecation warning for the last time

Run Details

0.62 hits per line

629 of 3937 relevant lines covered (15.98%)