6
97%
master: 97%

Ran 14 Jul 2017 01:03PM UTC

Files 145

Run time 5s

Badge

Embed ▾

Committed 14 Jul 2017 12:56PM UTC coverage: 98.901% (+0.002%) from 98.899%

Job # 2.4.1, gemfiles/rails_5.gemfile

Build Type

push

travis-ci

Committed by

dblock

Commit Message

[Bugfix] Handle deeply-nested dependent params (#1661)

* Repro issue #1659

* [Fix] Handle deeply-nested dependencies with `given`.

Behind the scenes, each call to `requires` or other params DSL method
pushes an entry onto a flat list of validators. The nesting structure
that your parameters can take on is tracked as an up-tree separately
on each scope, but that relationship isn't used to traverse the validations.
So, when I moved the dependency checking out of `should_validate?` and into
the actual validation, the `given` dependency stopped taking effect after
you nested parameters more than one level deep underneath.

To restore the behavior, I made the validation check recursively upwards
to see if it should or should not validate that scope.

* Add changelog entry.

Run Details

11339 of 11465 relevant lines covered (98.9%)

28.25 hits per line

ruby-grape / grape / 3022 / 6
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3022.6 (2.4.1, gemfiles/rails_5.gemfile)

ruby-grape / grape / 3022 / 6 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3022.6 (2.4.1, gemfiles/rails_5.gemfile)

ruby-grape / grape / 3022 / 6
97%
master: 97%

README BADGES
x