3022
97%

Ran 14 Jul 2017 12:58PM UTC

Jobs 18

Files 145

Run time 10min

Badge

Embed ▾

pending completion

Build # 3022

Build Type

push

travis-ci

Committed by

dblock

Commit Message

[Bugfix] Handle deeply-nested dependent params (#1661)

* Repro issue #1659

* [Fix] Handle deeply-nested dependencies with `given`.

Behind the scenes, each call to `requires` or other params DSL method
pushes an entry onto a flat list of validators. The nesting structure
that your parameters can take on is tracked as an up-tree separately
on each scope, but that relationship isn't used to traverse the validations.
So, when I moved the dependency checking out of `should_validate?` and into
the actual validation, the `given` dependency stopped taking effect after
you nested parameters more than one level deep underneath.

To restore the behavior, I made the validation check recursively upwards
to see if it should or should not validate that scope.

* Add changelog entry.

Run Details

11340 of 11465 relevant lines covered (98.91%)

451.75 hits per line

Jobs

ID	Job ID	Ran	Coverage
2	3022.2 (2.4.1, Gemfile)	14 Jul 2017 12:58PM UTC	98.9	Travis Job 3022.2
3	3022.3 (2.4.1, gemfiles/rack_edge.gemfile)	14 Jul 2017 12:59PM UTC	98.9	Travis Job 3022.3
4	3022.4 (2.4.1, gemfiles/rack_1.5.2.gemfile)	14 Jul 2017 12:59PM UTC	98.9	Travis Job 3022.4
5	3022.5 (2.4.1, gemfiles/rails_edge.gemfile)	14 Jul 2017 12:59PM UTC	98.9	Travis Job 3022.5
6	3022.6 (2.4.1, gemfiles/rails_5.gemfile)	14 Jul 2017 01:03PM UTC	98.9	Travis Job 3022.6
7	3022.7 (2.4.1, gemfiles/multi_json.gemfile)	14 Jul 2017 01:02PM UTC	60.0	Travis Job 3022.7
8	3022.8 (2.4.1, gemfiles/multi_xml.gemfile)	14 Jul 2017 01:01PM UTC	60.0	Travis Job 3022.8
9	3022.9 (2.3.4, Gemfile)	14 Jul 2017 01:03PM UTC	98.9	Travis Job 3022.9
10	3022.10 (2.3.4, gemfiles/rack_edge.gemfile)	14 Jul 2017 01:02PM UTC	98.9	Travis Job 3022.10
11	3022.11 (2.3.4, gemfiles/rack_1.5.2.gemfile)	14 Jul 2017 01:04PM UTC	98.9	Travis Job 3022.11
12	3022.12 (2.3.4, gemfiles/rails_edge.gemfile)	14 Jul 2017 01:04PM UTC	98.9	Travis Job 3022.12
13	3022.13 (2.3.4, gemfiles/rails_5.gemfile)	14 Jul 2017 01:05PM UTC	98.9	Travis Job 3022.13
14	3022.14 (2.2.7, Gemfile)	14 Jul 2017 01:06PM UTC	98.9	Travis Job 3022.14
15	3022.15 (2.2.7, gemfiles/rack_1.5.2.gemfile)	14 Jul 2017 01:05PM UTC	98.9	Travis Job 3022.15
16	3022.16 (2.2.7, gemfiles/rails_5.gemfile)	14 Jul 2017 01:08PM UTC	98.9	Travis Job 3022.16
17	3022.17 (2.2.7, gemfiles/rails_4.gemfile)	14 Jul 2017 01:09PM UTC	98.9	Travis Job 3022.17
18	3022.18 (2.2.7, gemfiles/rails_3.gemfile)	14 Jul 2017 01:08PM UTC	98.9	Travis Job 3022.18
19	3022.19 (ruby-head)	14 Jul 2017 01:09PM UTC	98.9	Travis Job 3022.19

Source Files on build 3022

Detailed source file information is not available for this build.

ruby-grape / grape / 3022
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3022

ruby-grape / grape / 3022 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3022

ruby-grape / grape / 3022
97%

README BADGES
x