ruby-grape / grape / 26331584349 / 36

97%

master: 97%

Pull #2737

github

Make rescue_from reject meta selectors mixed with exception classes

Previously the `*args` signature meant that:

  rescue_from :all, MyError, with: :handler

silently dropped `MyError`: the `if args.include?(:all)` branch fired
and the trailing argument was never registered. Same for
`:grape_exceptions` and `:internal_grape_exceptions`.

Keep the existing `*args` signature, add a single guard above the
dispatch: if any meta selector is present and `args.size > 1`, raise
`ArgumentError`. Valid forms (`rescue_from :all`,
`rescue_from :all, with:`, `rescue_from MyError, OtherError, with:`)
are unaffected.

CHANGELOG + UPGRADING entries added; three new request_response_spec
examples cover the new ArgumentError contract.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

1064 of 1173 branches covered (90.71%)

Branch coverage included in aggregate %.

3491 of 3587 relevant lines covered (97.32%)

988.6 hits per line