ruby-grape / grape / 26331584349

97%

master: 97%

Build Type

Pull #2737

github

Committed by ericproulx

Commit Message

Make rescue_from reject meta selectors mixed with exception classes

Previously the `*args` signature meant that:

  rescue_from :all, MyError, with: :handler

silently dropped `MyError`: the `if args.include?(:all)` branch fired
and the trailing argument was never registered. Same for
`:grape_exceptions` and `:internal_grape_exceptions`.

Keep the existing `*args` signature, add a single guard above the
dispatch: if any meta selector is present and `args.size > 1`, raise
`ArgumentError`. Valid forms (`rescue_from :all`,
`rescue_from :all, with:`, `rescue_from MyError, OtherError, with:`)
are unaffected.

CHANGELOG + UPGRADING entries added; three new request_response_spec
examples cover the new ArgumentError contract.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #2737: Make rescue_from reject meta selectors mixed with exception classes

Coverage Stats

1090 of 1175 branches covered (92.77%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

3536 of 3595 relevant lines covered (98.36%)

31618.66 hits per line