decentraland / comms-gatekeeper / 25191624580 / 1

85%

main: 85%

push

github

fix: prevent 500 in /scene-admin when no profiles resolve (#260)

* fix: prevent 500 in /scene-admin when no profiles resolve

getNamesFromAddresses threw ProfilesNotFoundError when its result map ended
up empty, and the central error handler had no mapping for it — so the
endpoint returned 500 whenever every admin in a place had no profile entry.

Remove the throw and return the (possibly empty) record. All consumers
already coalesce missing names with `|| ''`, so the throw was never
load-bearing.

* fix: scene-bans listSceneBans log count and name fallback

Two pre-existing nits flagged in review on the same code path:

- The "Successfully listed N bans for place" log read .length on a
  Record, which is always undefined. Use Object.keys(...).length.
- bannedNames[address] could be undefined for addresses with no profile,
  silently violating the SceneBanAddressWithName.name: string contract.
  Coalesce to '' to match the scene-admin handler's behavior.

1138 of 1452 branches covered (78.37%)

Branch coverage included in aggregate %.

5900 of 6684 relevant lines covered (88.27%)

21.75 hits per line