decentraland / comms-gatekeeper / 25191624580

85%

Build Type

push

github

Committed by web-flow

Commit Message

fix: prevent 500 in /scene-admin when no profiles resolve (#260)

* fix: prevent 500 in /scene-admin when no profiles resolve

getNamesFromAddresses threw ProfilesNotFoundError when its result map ended
up empty, and the central error handler had no mapping for it — so the
endpoint returned 500 whenever every admin in a place had no profile entry.

Remove the throw and return the (possibly empty) record. All consumers
already coalesce missing names with `|| ''`, so the throw was never
load-bearing.

* fix: scene-bans listSceneBans log count and name fallback

Two pre-existing nits flagged in review on the same code path:

- The "Successfully listed N bans for place" log read .length on a
  Record, which is always undefined. Use Object.keys(...).length.
- bannedNames[address] could be undefined for addresses with no profile,
  silently violating the SceneBanAddressWithName.name: string contract.
  Coalesce to '' to match the scene-admin handler's behavior.

Coverage Stats

1047 of 1344 branches covered (77.9%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

2950 of 3342 relevant lines covered (88.27%)

43.5 hits per line