open-quantum-safe / liboqs / 24851002424 / 1
82%
main: 82%

DEFAULT BRANCH: main
Ran
Files 1259
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.376% (+0.005%) from 85.371%
24851002424.1

push

github

web-flow 
Fix Reading beyond buffer end (#2384)

* Validate signature lengths when verifying a signature.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Fix test build problem.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Fix test build problem.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Test invalid signature length.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Fix formating.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Update sig_stfl_xmss.h

Update per review. Remove duplicate macro definition.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Updates per comments.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Fix formatting.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Update xmss tests.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Address test  failures.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Fix test_sig_stfl pthread path: activate and wire up rc2

The pthread branch in test_sig_stfl.c was gated on
OQS_USE_PTHREADS_IN_TESTS, which stopped being defined when PR #1576
(Oct 2023) migrated test_kem.c and test_sig.c to CMAKE_USE_PTHREADS_INIT.
test_sig_stfl.c (added later in PR #1650) kept using the old name, so
its pthread branch has never compiled. Rename to OQS_USE_PTHREADS to
match the sibling tests and activate the code.

Activating the branch exposes two latent bugs introduced by the
invalid-signature test:
- test_correctness_wrapper referenced `alg_name` (a main()-local) instead
  of `td->alg_name`; fix to use the struct field.
- thread_data_t.rc2 was set by the wrapper but never propagated back
  into main()'s rc2 check, making the new invalid-signature test a
  no-op on pthread builds. Initialize .rc2 = OQS_SUCCESS, copy td.rc2
  after pthread_join, and include rc2 in the pthread-path exit check
  to mirror the non-pthread path.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>

* Fix test_sig_stfl... (continued)

78403 of 91833 relevant lines covered (85.38%)

8889624.43 hits per line

Source Files on job x64-generic - 24851002424.1