open-quantum-safe / liboqs / 24851002424
82%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 2878
Run time 6min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.268% (-0.001%) from 82.269%
24851002424

push

github

web-flow 
Fix Reading beyond buffer end (#2384)

* Validate signature lengths when verifying a signature.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Fix test build problem.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Fix test build problem.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Test invalid signature length.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Fix formating.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Update sig_stfl_xmss.h

Update per review. Remove duplicate macro definition.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Updates per comments.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Fix formatting.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Update xmss tests.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Address test  failures.

Signed-off-by: Norman Ashley <nashley@cisco.com>

* Fix test_sig_stfl pthread path: activate and wire up rc2

The pthread branch in test_sig_stfl.c was gated on
OQS_USE_PTHREADS_IN_TESTS, which stopped being defined when PR #1576
(Oct 2023) migrated test_kem.c and test_sig.c to CMAKE_USE_PTHREADS_INIT.
test_sig_stfl.c (added later in PR #1650) kept using the old name, so
its pthread branch has never compiled. Rename to OQS_USE_PTHREADS to
match the sibling tests and activate the code.

Activating the branch exposes two latent bugs introduced by the
invalid-signature test:
- test_correctness_wrapper referenced `alg_name` (a main()-local) instead
  of `td->alg_name`; fix to use the struct field.
- thread_data_t.rc2 was set by the wrapper but never propagated back
  into main()'s rc2 check, making the new invalid-signature test a
  no-op on pthread builds. Initialize .rc2 = OQS_SUCCESS, copy td.rc2
  after pthread_join, and include rc2 in the pthread-path exit check
  to mirror the non-pthread path.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>

* Fix test_sig_stfl... (continued)

207971 of 252797 relevant lines covered (82.27%)

8204541.97 hits per line

Coverage Regressions

Lines Coverage ∆ File
3
96.44
 -0.27% src/sig/falcon/pqclean_falcon-1024_aarch64/keygen.c
2
73.7
 -0.45% src/sig/ml_dsa/mldsa-native_ml-dsa-65_ref/mldsa/src/sign.c
2
61.9
 -0.45% src/sig/ml_dsa/mldsa-native_ml-dsa-65_x86_64/mldsa/src/sign.c
1
95.92
 -2.04% src/kem/classic_mceliece/pqclean_mceliece460896_avx2/encrypt.c
1
97.3
 -1.35% src/kem/classic_mceliece/pqclean_mceliece460896_clean/pk_gen.c
1
96.72
 -1.64% src/kem/classic_mceliece/pqclean_mceliece460896f_clean/encrypt.c
1
95.83
 -4.17% src/sig/ml_dsa/mldsa-native_ml-dsa-44_ref/mldsa/src/rounding.h
1
33.33
 -4.17% src/sig/ml_dsa/mldsa-native_ml-dsa-65_aarch64/mldsa/src/rounding.h
1
33.33
 -4.17% src/sig/ml_dsa/mldsa-native_ml-dsa-65_x86_64/mldsa/src/rounding.h
1
33.33
 -4.17% src/sig/ml_dsa/mldsa-native_ml-dsa-87_x86_64/mldsa/src/rounding.h
1
93.75
 -1.56% src/sig/uov/pqov_ov_Is_pkc_skc_neon/ov.c
1
93.55
 -1.61% src/sig/uov/pqov_ov_Is_pkc_skc_ref/ov.c
1
95.65
 -2.17% src/sig/uov/pqov_ov_Is_ref/ov.c
Jobs
ID Job ID Ran Files Coverage
1 x64-generic - 24851002424.1 1259
85.38
 GitHub Action Run
2 arm64-distbuild - 24851002424.2 1789
60.29
 GitHub Action Run
3 x64-distbuild - 24851002424.3 2347
56.5
 GitHub Action Run
Source Files on build 24851002424