open-quantum-safe / liboqs
80%

DEFAULT BRANCH: main
Repo Added
Files 2452
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 80.359% (-0.002%) from 80.361%
35354665037

push

github

web-flow 
Fix AND separator in ARM64 required_flags CMake guard (#2567)

The Jinja loop that emits the ARM64_V8 instruction-flag guard in
add_enable_by_alg_conditional.fragment used

    {%- if not loop.last or loop.first %} AND {% endif -%}

which places the separator *before* the first flag and omits it before
the last. With a single required flag the two mistakes cancel out and
the output is the harmless duplicate

    OQS_USE_ARM_NEON_INSTRUCTIONS AND OQS_USE_ARM_NEON_INSTRUCTIONS

but with two or more flags the last two tokens are concatenated:

    OQS_USE_ARM_NEON_INSTRUCTIONS AND OQS_USE_ARM_NEON_INSTRUCTIONSOQS_USE_ARM_SHA3_INSTRUCTIONS

CMake treats the concatenated name as an undefined variable, which is
false, so the whole conjunction is false and the NEON implementation can
only ever be enabled via OQS_DIST_ARM64_V8_BUILD -- never through
OQS_USE_ARM_NEON_INSTRUCTIONS/OQS_USE_ARM_SHA3_INSTRUCTIONS.

Emit " AND " before every flag instead. The leading
OQS_USE_ARM_NEON_INSTRUCTIONS is already written out by the template, so
this renders identically for single-flag platforms (all 44 existing
lines are byte-for-byte unchanged) and correctly for two or more.

Regenerate .CMake/alg_support.cmake: 18 lines, all mqom neon guards, the
only platform in-tree with two ARM required_flags (asimd + sha3).

Signed-off-by: Eva Crystal <0xiviel@gmail.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

176255 of 219335 relevant lines covered (80.36%)

3582388.32 hits per line

Relevant lines Covered
219335 RELEVANT LINES 176255 COVERED LINES
3582388.32 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
35354665037 main Fix AND separator in ARM64 required_flags CMake guard (#2567) The Jinja loop that emits the ARM64_V8 instruction-flag guard in add_enable_by_alg_conditional.fragment used {%- if not loop.last or loop.first %} AND {% endif -%} which places t... push web-flow github
80.36
35234139226 fix/arm-neon-required-flags-separator Merge 1e75c334d into dcf6b0e45 Pull #2567 web-flow github
80.37
35233847903 main build(cmake): allow CMAKE_POSITION_INDEPENDENT_CODE to be overridden (#2524) * build(cmake): allow CMAKE_POSITION_INDEPENDENT_CODE to be overridden CMakeLists.txt hardcoded `set(CMAKE_POSITION_INDEPENDENT_CODE ON)`. Because that creates a normal... push web-flow github
80.36
34668970920 fix/arm-neon-required-flags-separator Merge 2d20157e3 into adbeba1ef Pull #2567 web-flow github
81.16
35145418084 fix/1882-optional-position-independent-code Merge a2402c31e into cf096a27a Pull #2524 web-flow github
80.36
35145046390 main Bump the github-actions group with 3 updates (#2573) Bumps the github-actions group with 3 updates: [DeterminateSystems/nix-installer-action](https://github.com/determinatesystems/nix-installer-action), [actions/upload-artifact](https://github.co... push web-flow github
80.37
35145022563 main Bump gitpython (#2572) Bumps the pip group with 1 update in the /scripts/copy_from_upstream directory: [gitpython](https://github.com/gitpython-developers/GitPython). Updates `gitpython` from 3.1.61 to 3.1.62 - [Release notes](https://github.co... push web-flow github
80.36
35144436914 dependabot/pip/scripts/copy_from_upstream/pip-c86b6bad83 Merge c9625b0f2 into aaa544a79 Pull #2572 web-flow github
80.37
35144556538 dependabot/github_actions/github-actions-9884347997 Merge de446f371 into aaa544a79 Pull #2573 web-flow github
80.37
35132260561 mb-ci-runtimereport Merge c83e8f8cb into dec0584c9 Pull #2493 web-flow github
83.39
See All Builds (688)