open-quantum-safe / liboqs / 24726525961 / 1
82%
main: 82%

DEFAULT BRANCH: main
Ran
Files 1259
Run time 45s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.382% (+0.01%) from 85.371%
24726525961.1

push

github

web-flow 
Move compiler optimization level to CMAKE_BUILD_TYPE (#2383)

* autoformat compiler_opts.cmake to improve readability

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* Removed superfluous add_compile_options(-O3)

CMAKE_BUILD_TYPE=Release will apply -O3 to all compile commands already.
There is no need to explicitly add another -O3.

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* Set CMAKE_BUILD_TYPE default; document CMAKE_BUILD_TYPE and escape hatch

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* Patch snova to suppress unused parameter warnings

Under CMAKE_BUILD_TYPE=Release|RelWithDebInfo|MinSizeRel, cmake will add
-DNDEBUG to the set of C flags. With NDEBUG, the `assert` macro from
`<assert.h>` expands to nothing, so a parameter that is only used in
`assert` becomes unused. This commit adds a `(void) xxx` when `NDEBUG`
is defined to suppress unused parameter warnings.

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* Guard CMAKE_BUILD_TYPE default for multi-config generators

On multi-configuration generators (Xcode, Visual Studio, Ninja
Multi-Config) CMAKE_BUILD_TYPE is unused — the configuration is
selected at build time via --config. Unconditionally defaulting it to
Release set the variable to a misleading value and caused
OQS_DEBUG_BUILD (which keys off CMAKE_BUILD_TYPE) to always compute
OFF, silently dropping debug-only compile options when building the
Debug configuration in Xcode/VS.

Guard the default with GENERATOR_IS_MULTI_CONFIG so it only applies on
single-config generators, and update CONFIGURE.md to clarify the
default's scope, fix the now-stale Debug description, mention
CMAKE_C_FLAGS as an additional escape hatch, and a small copy-edit.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>

---------

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Signed-off-by: Douglas Stebila <dstebila@users.noreply.github.com>
Signed-... (continued)

78409 of 91833 relevant lines covered (85.38%)

8890689.53 hits per line

Source Files on job x64-generic - 24726525961.1