open-quantum-safe / liboqs / 24726525961
82%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 2878
Run time 6min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.279% (+0.01%) from 82.268%
24726525961

push

github

web-flow 
Move compiler optimization level to CMAKE_BUILD_TYPE (#2383)

* autoformat compiler_opts.cmake to improve readability

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* Removed superfluous add_compile_options(-O3)

CMAKE_BUILD_TYPE=Release will apply -O3 to all compile commands already.
There is no need to explicitly add another -O3.

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* Set CMAKE_BUILD_TYPE default; document CMAKE_BUILD_TYPE and escape hatch

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* Patch snova to suppress unused parameter warnings

Under CMAKE_BUILD_TYPE=Release|RelWithDebInfo|MinSizeRel, cmake will add
-DNDEBUG to the set of C flags. With NDEBUG, the `assert` macro from
`<assert.h>` expands to nothing, so a parameter that is only used in
`assert` becomes unused. This commit adds a `(void) xxx` when `NDEBUG`
is defined to suppress unused parameter warnings.

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

* Guard CMAKE_BUILD_TYPE default for multi-config generators

On multi-configuration generators (Xcode, Visual Studio, Ninja
Multi-Config) CMAKE_BUILD_TYPE is unused — the configuration is
selected at build time via --config. Unconditionally defaulting it to
Release set the variable to a misleading value and caused
OQS_DEBUG_BUILD (which keys off CMAKE_BUILD_TYPE) to always compute
OFF, silently dropping debug-only compile options when building the
Debug configuration in Xcode/VS.

Guard the default with GENERATOR_IS_MULTI_CONFIG so it only applies on
single-config generators, and update CONFIGURE.md to clarify the
default's scope, fix the now-stale Debug description, mention
CMAKE_C_FLAGS as an additional escape hatch, and a small copy-edit.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>

---------

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Signed-off-by: Douglas Stebila <dstebila@users.noreply.github.com>
Signed-... (continued)

207998 of 252797 relevant lines covered (82.28%)

8199260.3 hits per line

Coverage Regressions

Lines Coverage ∆ File
59
0.0
 -100.0% src/kem/bike/additional_r4/decode_avx512.c
46
0.0
 -100.0% src/kem/bike/additional_r4/gf2x_mul_avx512.c
37
0.0
 -100.0% src/kem/bike/additional_r4/gf2x_ksqr_avx512.c
29
0.0
 -48.33% src/common/sha3/avx512vl_sha3.c
27
0.0
 -100.0% usr/lib/gcc/x86_64-linux-gnu/13/include/avx512fintrin.h
22
0.0
 -100.0% src/kem/bike/additional_r4/sampling_avx512.c
18
0.0
 -75.0% src/common/sha3/avx512vl_sha3x4.c
5
0.0
 -100.0% usr/lib/gcc/x86_64-linux-gnu/13/include/avx512bwintrin.h
2
61.99
 -0.45% src/sig/ml_dsa/mldsa-native_ml-dsa-87_x86_64/mldsa/src/sign.c
1
96.08
 -1.96% src/kem/classic_mceliece/pqclean_mceliece348864_avx2/encrypt.c
1
96.23
 -0.09% src/sig/falcon/pqclean_falcon-1024_avx2/keygen.c
1
76.7
 -0.49% src/sig/falcon/pqclean_falcon-1024_avx2/vrfy.c
1
96.51
 0.17% src/sig/falcon/pqclean_falcon-1024_clean/keygen.c
1
76.7
 -0.49% src/sig/falcon/pqclean_falcon-1024_clean/vrfy.c
1
95.55
 -0.09% src/sig/falcon/pqclean_falcon-512_clean/keygen.c
1
33.33
 -4.17% src/sig/ml_dsa/mldsa-native_ml-dsa-65_aarch64/mldsa/src/rounding.h
1
95.65
 -2.17% src/sig/uov/pqov_ov_Is_neon/ov.c
1
95.65
 -2.17% src/sig/uov/pqov_ov_Is_ref/ov.c
Jobs
ID Job ID Ran Files Coverage
1 x64-generic - 24726525961.1 1259
85.38
 GitHub Action Run
2 arm64-distbuild - 24726525961.2 1789
60.29
 GitHub Action Run
3 x64-distbuild - 24726525961.3 2347
56.51
 GitHub Action Run
Source Files on build 24726525961