pantsbuild
/
pants
/
24036376966
/
2
93%
main: 93%
main: 93%
|
Ran
|
Files
1200
|
Run time
36s
|
Badge
Embed ▾
README BADGES
|
coverage: 53.897% (-0.001%) from 53.898%
push
github
web-flowreduce workunit terminal display to one decimal (#23215) Currently we have a render rate of 10 Hz <https://github.com/pantsbuild/pants/blob/9b3c1562e/src/rust/ui/src/lib.rs#L38> but try to display out to two decimal places. This results in some awkward displays where the last digit will look stuck -- 1.25 --> 1.35 --> 1.45 -- until some jitter aligns it to a new digit for a bit. Since this is just for a visual display and humans can't actually count that fast, I think it's fine to show one digit after the decimal. This is the granularity of `docker` for example. Before: https://github.com/user-attachments/assets/c8ab5bf5-3336-44f2-ba14-76b887160715 After: https://github.com/user-attachments/assets/73b18e94-9097-49c9-a493-3e748ad5ccb2 An alternative approach would be to render at 100 Hz, but I don't think displaying the digit just to "look cool" is worth becoming terminal performance experts. Disclosure: Claude connected the `render_interval`/`render_rate_hz`/`render` math together, and made the change.
33353 of 61883 relevant lines covered (53.9%)
0.54 hits per line
