pantsbuild
/
pants
/
24036376966
93%
|
Ran
|
Jobs
11
|
Files
1733
|
Run time
4min
|
Badge
Embed ▾
README BADGES
|
coverage: 92.907% (-0.001%) from 92.908%
push
github
web-flowreduce workunit terminal display to one decimal (#23215) Currently we have a render rate of 10 Hz <https://github.com/pantsbuild/pants/blob/9b3c1562e/src/rust/ui/src/lib.rs#L38> but try to display out to two decimal places. This results in some awkward displays where the last digit will look stuck -- 1.25 --> 1.35 --> 1.45 -- until some jitter aligns it to a new digit for a bit. Since this is just for a visual display and humans can't actually count that fast, I think it's fine to show one digit after the decimal. This is the granularity of `docker` for example. Before: https://github.com/user-attachments/assets/c8ab5bf5-3336-44f2-ba14-76b887160715 After: https://github.com/user-attachments/assets/73b18e94-9097-49c9-a493-3e748ad5ccb2 An alternative approach would be to render at 100 Hz, but I don't think displaying the digit just to "look cool" is worth becoming terminal performance experts. Disclosure: Claude connected the `render_interval`/`render_rate_hz`/`render` math together, and made the change.
91540 of 98529 relevant lines covered (92.91%)
3.72 hits per line
Coverage Regressions
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 1 |
93.53 |
-0.43% | src/python/pants/backend/python/providers/python_build_standalone/rules.py |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | test_python_linux_x86_64_0/10 - 24036376966.1 | 1209 |
56.8 |
GitHub Action Run | |
| 2 | test_python_linux_x86_64_9/10 - 24036376966.2 | 1200 |
53.9 |
GitHub Action Run | |
| 3 | test_python_linux_x86_64_1/10 - 24036376966.3 | 1188 |
49.19 |
GitHub Action Run | |
| 4 | test_python_linux_x86_64_4/10 - 24036376966.4 | 1224 |
59.4 |
GitHub Action Run | |
| 5 | test_python_linux_x86_64_5/10 - 24036376966.5 | 1204 |
59.72 |
GitHub Action Run | |
| 6 | test_python_linux_x86_64_6/10 - 24036376966.6 | 1185 |
49.54 |
GitHub Action Run | |
| 7 | test_python_linux_x86_64_8/10 - 24036376966.7 | 1191 |
53.59 |
GitHub Action Run | |
| 8 | test_python_linux_x86_64_2/10 - 24036376966.8 | 1191 |
58.66 |
GitHub Action Run | |
| 9 | test_python_linux_x86_64_7/10 - 24036376966.9 | 1195 |
51.29 |
GitHub Action Run | |
| 10 | test_python_linux_x86_64_3/10 - 24036376966.10 | 1189 |
53.84 |
GitHub Action Run | |
| 11 | test_python_macos14_arm64 - 24036376966.11 | 1173 |
52.37 |
GitHub Action Run |
