kobotoolbox / kpi / 21965675470 / 1

82%

master: 76%

push

github

feat(assetNavigator): migrate to TypeScript and remove searches DEV-1323 DEV-1322 (#6653)

### 💭 Notes

`AssetNavigator` is the piece of code that we use in Form Builder to
"Add from Library". Previously it was using `searches` and mix of other
Reflux actions to display the search with tags and collection filtering.
Now it uses orval (react-query).

It looks a bit different than before, beacuse:

1. It was old and ugly
2. I am using Mantine :)

Changes here:
- Deleted `jsapp/js/components/list.js` as we no longer use any of
components from it. They were used only single time in the
`assetNavigator.js`
- Deleted bunch of (now) unused bem components (and their css styles)
- `assetNavigator.js` is now `AssetNavigator.tsx` and uses react-query
- Added `AssetNavigatorCard` for displaying small draggable asset in the
search results
- Deleted one obsolete reflux action (`listTags`)
- Moved obscure Sentry call to `AssetNavigator`
- Improved `parseTags` to work with `Asset` object (orval's
`AssetResponse`)
- Deleted unusued `assetNavExpanded` from `PageStateStore`
- Deleted obsolete `stores.tags` store
- Added a hackfix in `view.surveyApp.coffee` to avoid UI crashing. Not
sure why the changes in this PR caused this to happen, given
CoffeeScript code was not touched. I spent some time debugging this
(crash was easily reproducible), but ended up just having a fix that
works, rather than spending more and more hours trying to understand
Backbone x CoffeeScript x JQuery split :)
- The bug was: after creating a new question, the "+" button is focused,
you delete the question (while keeping "+" focused) = you get UI crash
- Used our existing `<Badge>` with new `xs` size, as it was quicker than
setting up Mantine's `Badge`

### 👀 Preview steps

1. ℹ️ have an account and bunch of projects in the Library:
   - A single question
   - A block of questions
   - A template
   - A collection with single question and block of questions
   - Few of above items with tags
2. Go... (continued)

7225 of 11502 branches covered (62.82%)

27681 of 34735 relevant lines covered (79.69%)

0.8 hits per line