Instagram
/
IGListKit
/
20972428095
/
1
99%
master: 100%
master: 100%
|
Ran
|
Files
59
|
Run time
2s
|
Badge
Embed ▾
README BADGES
|
coverage: 95.674% (-0.1%) from 95.779%
push
github
meta-codesync[bot]improve assert details in IGListAdapter+UICollectionView Summary: These asserts could be very helpful to debug tricky crashes, but they don't tell us enough about which object/section-controller are returning invalid data. The backtrace itself doesn't have the info. Lets: * Add object and section-controller class names, but don't include the entire object description (can be very long) * Clean up how we print NSIndexPath without the memory address. This can make group-by a lot more useful. ## Examples Before: > IGListAdapter returned NaN height = nan for item at indexPath <<NSIndexPath: 0x90c0bb66134b9c8a> {length = 2, path = 0 - 0}> After: > IGListAdapter returned NaN width = nan {indexPath: 0-0, object: IGFooViewerLoadingModel, sectionController:IGFooLoadingSectionController, dataSource: IGFooDataSource} Before: > Section controller nil for section 1 After: > Section controller is nil {indexPath: 1-0, object: IGStoryFooViewModel, sectionController: nil, dataSource: IGFooDataSource} Differential Revision: D90555737 fbshipit-source-id: 7a993ce66
4357 of 4554 relevant lines covered (95.67%)
693.3 hits per line
