Instagram / IGListKit / 20972428095

99%

master: 100%

push

github

improve assert details in IGListAdapter+UICollectionView

Summary:
These asserts could be very helpful to debug tricky crashes, but they don't tell us enough about which object/section-controller are returning invalid data. The backtrace itself doesn't have the info.

Lets:
* Add object and section-controller class names, but don't include the entire object description (can be very long)
* Clean up how we print NSIndexPath without the memory address. This can make group-by a lot more useful.

## Examples

Before:
>  IGListAdapter returned NaN height = nan for item at indexPath <<NSIndexPath: 0x90c0bb66134b9c8a> {length = 2, path = 0 - 0}>

After:
> IGListAdapter returned NaN width = nan {indexPath: 0-0, object: IGFooViewerLoadingModel, sectionController:IGFooLoadingSectionController, dataSource: IGFooDataSource}

Before:
> Section controller nil for section 1

After:
> Section controller is nil {indexPath: 1-0, object: IGStoryFooViewModel, sectionController: nil, dataSource: IGFooDataSource}

Differential Revision: D90555737

fbshipit-source-id: 7a993ce66

9 of 14 new or added lines in 1 file covered. (64.29%)

4345 of 4536 relevant lines covered (95.79%)

696.05 hits per line