Instagram / IGListKit
96%
master: 100%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Repo Added
Files 54
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 95.895%. Remained the same
20127244776

push

github

meta-codesync[bot] 
Enable unit test suite for tvOS (#1649)

Summary:
## Changes in this pull request

Following up on https://github.com/instagram/IGListKit/issues/1401! This PR pulls in koenpunt's PR for tvOS test support and updates it against the latest version of IGListKit.

A few changes:

* I disabled the unit tests that require storyboards/NIBs for tvOS since we only have iOS formatted assets. We can follow this up in a future PR if need be.
* Rewrote the Travis build command for GitHub Actions
* Went through and gated any UIKit APIs that aren't available on tvOS.
* A few unit tests were failing since UICollectionView on tvOS does have a few implicit behavioral differences. I gated these for now, but if anyone using IGListKit on tvOS actually encounters these errors, please open an issue so we can track it and adjust our test suite accordingly.

### Checklist

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md)

Pull Request resolved: https://github.com/instagram/IGListKit/pull/1649

Reviewed By: jurmarcus

Differential Revision: D88921781

Pulled By: TimOliver

fbshipit-source-id: fb8b0becd

4345 of 4531 relevant lines covered (95.89%)

696.82 hits per line

Relevant lines Covered
4531 RELEVANT LINES 4345 COVERED LINES
696.82 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
20127244776 main Enable unit test suite for tvOS (#1649) Summary: ## Changes in this pull request Following up on https://github.com/instagram/IGListKit/issues/1401! This PR pulls in koenpunt's PR for tvOS test support and updates it against the latest version o... push meta-codesync[bot] github
95.89
20125504208 tvos-tests Merge ae64bd2b7 into 7dddb0d4c Pull #1649 web-flow github
95.89
20125346470 tvos-tests Merge 35f0c3c66 into 7dddb0d4c Pull #1649 web-flow github
95.89
20125280445 tvos-tests Merge f0862322f into 7dddb0d4c Pull #1649 web-flow github
95.89
20124198690 tvos-tests Merge 79567b0eb into 7dddb0d4c Pull #1649 web-flow github
95.89
20123356120 tvos-tests Merge 11d13a526 into 7dddb0d4c Pull #1649 web-flow github
95.89
20123258124 tvos-tests Merge 8c53e9e05 into 7dddb0d4c Pull #1649 web-flow github
95.89
20123067488 tvos-tests Merge 8eb5a21d8 into 7dddb0d4c Pull #1649 web-flow github
95.89
19971554387 main Formalize that the IGListAdapterDelegateAnnouncer is main-thread affined Summary: Today, the IGListAdapterDelegateAnnouncer is different than most other announcers in IG/FB/etc in that it not thread safe to add and remove listeners. However, thi... push meta-codesync[bot] github
95.89
19511011910 main fbsource//fbobjc/:30 Reviewed By: rmaz Differential Revision: D87420822 fbshipit-source-id: 4d9b44b47 push meta-codesync[bot] github
95.91
See All Builds (1592)