1
77%
master: 77%

Ran 22 Oct 2023 01:27PM UTC

Files 339

Run time 8s

Badge

Embed ▾

Committed 21 Oct 2023 08:20PM UTC coverage: 86.179% (-1.3%) from 87.459%

Job # #37659.1

Build Type

push

local

Committed by

web-flow

Commit Message

Throw OverflowError on typemin(Int)//(-1) (#51085)

Fixes #32443

Currently `typemin(Int)//(-1) == typemin(Int)//(1)`, ignoring an
overflow.

As noted by @JeffreySarnoff in
[#32443](https://github.com/JuliaLang/julia/issues/32443#issuecomment-506816722)
This should throw an error instead of silently overflowing.

To fix this I am using `checked_neg` instead of `-` in the Rational
constructor.

With this PR `(-one(T))//typemin(T)` will now also throw an
`OverflowError` instead of an `ArgumentError`

Run Details

72449 of 84068 relevant lines covered (86.18%)

12247769.91 hits per line

JuliaLang / julia / #37659 / 1
77%
master: 77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job #37659.1

JuliaLang / julia / #37659 / 1 77% master: 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job #37659.1

JuliaLang / julia / #37659 / 1
77%
master: 77%

README BADGES
x