JuliaLang / julia
88%

DEFAULT BRANCH: master
Repo Added
Files 383
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: SELECT
CHANGE BRANCH
x

coverage: 88.175% (-0.008%) from 88.183%
746

push

buildkite

web-flow 
core: Fix more odd-width primitive bugs (#63408)

Primitive types whose width is not a multiple of 8, supported since
#61359, still hit several bugs:

- runtime intrinsics left the bits above a result's width set:
  `sext_int` filled them with the sign, and `flipsign_int` and
  out-of-range `fptoui`/`fptosi` kept them. `===` ignores those bits,
  but constants folded by inference carried them into package images;
- the runtime shifts counted the bits above an amount's width;
- the runtime shifts took an amount modulo 2^N for an N-bit value,
  where codegen shifts everything out, at standard widths too;
- redefining a primitive type with another width of the same size kept
  the old type;
- `@enum`, `Core.check_top_bit` and the multiplicative inverses took
  the width from `8 * sizeof`, and `Core.check_top_bit` threw on types
  narrower than 8 bits;
- a runtime `replacefield!` on a 1- or 2-byte primitive with padding
  bits failed spuriously, and asserted in debug builds.

The shifts get their own runtime wrapper, and the other integer
intrinsics pass their operands as they are: since #61359 no op reads
the sign-filled bytes they were extended with.

Fixes #63460

Co-authored-by: Cody Tapscott <topolarity@tapscott.me>
Assisted-by: Claude Code (Opus 5.5)
Assisted-by: Claude Code (Fable 5.1)

9 of 9 new or added lines in 3 files covered. (100.0%)

159 existing lines in 7 files now uncovered.

92120 of 104474 relevant lines covered (88.18%)

353.03 hits per line

Relevant lines Covered
104474 RELEVANT LINES 92120 COVERED LINES
353.03 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
746 master core: Fix more odd-width primitive bugs (#63408) Primitive types whose width is not a multiple of 8, supported since #61359, still hit several bugs: - runtime intrinsics left the bits above a result's width set: `sext_int` filled them with the... push web-flow buildkite
88.18
736 master reinterpretarray: fix offset indexing in pass-through wrappers (#63418) push web-flow buildkite
88.18
723 master Filesystem: guard `mv`/`cp` against overlapping paths (#63419) `mv` and `cp` only compared `src` and `dst` with `samefile`. With `force=true`, a destination containing the source was removed first, deleting the source: `mv("pkg/pkg-1.0", "pkg"; f... push web-flow buildkite
88.16
691 master type system: declare the `T` field of `TypeEq` as `Any` (#62948) `jl_valid_type_param` admits non-type values as type parameters, so `Type{1}` and `Type{setindex!}` are constructible (as on 1.13), and subtyping can also produce such types by bind... push web-flow buildkite
88.16
680 master intfuncs: Fix hex digit count for odd-width primitives (#63093) * intfuncs: Fix hex digit count for odd-width primitives `hex` derived the number of nibbles from `sizeof(x)`, the byte-rounded storage size, so a primitive type whose logical width... push web-flow buildkite
88.16
665 master LinearAlgebra number of default threads test should ignore (#63319) push web-flow buildkite
88.16
654 master REPL: Sync the ^C sweep test on the evaluation result (#63295) * REPL: Sync the ^C sweep test on the evaluation result In julia-pr build 2541 this test hung at the `Cancelled all in-flight work.` read and was hard-killed after the 900s timeout, ... push web-flow buildkite
88.14
646 master syntax versioning: Pass version to `Core._parse` (#63082) - `Meta.parse` and friends should parse using VERSION by default - Be slightly stricter when flisp parsing is asked for non-VERSION syntax - `__toplevel__.var"#_internal_julia_parse"` sh... push web-flow buildkite
88.15
636 master Test suite: Try `JULIA_TEST_HTTPBINGO_SERVER`, if it is defined (#60855) push web-flow buildkite
88.14
627 master subarray: support more index types for strides and pointer conversion (#62859) * subarray: support more index types for strides and pointer conversion Views indexed by integer ranges with a non-BitInteger eltype (e.g. BigInt) and by reshaped ran... push web-flow buildkite
88.13
See All Builds (6569)