#37659
77%

Ran 22 Oct 2023 01:27PM UTC

Jobs 1

Files 339

Run time 6s

Badge

Embed ▾

Committed 21 Oct 2023 08:20PM UTC coverage: 86.179% (-1.3%) from 87.459%

Build # #37659

Build Type

push

local

Committed by

web-flow

Commit Message

Throw OverflowError on typemin(Int)//(-1) (#51085)

Fixes #32443

Currently `typemin(Int)//(-1) == typemin(Int)//(1)`, ignoring an
overflow.

As noted by @JeffreySarnoff in
[#32443](https://github.com/JuliaLang/julia/issues/32443#issuecomment-506816722)
This should throw an error instead of silently overflowing.

To fix this I am using `checked_neg` instead of `-` in the Rational
constructor.

With this PR `(-one(T))//typemin(T)` will now also throw an
`OverflowError` instead of an `ArgumentError`

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

72449 of 84068 relevant lines covered (86.18%)

12247769.91 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	88.75	-0.31%	base/boot.jl
1	73.59	-0.3%	base/client.jl
1	86.11	-0.06%	base/compiler/tfuncs.jl
1	90.0	-5.45%	base/docs/bindings.jl
1	65.85	-0.16%	base/errorshow.jl
1	55.48	-0.33%	base/int.jl
1	92.19	-0.22%	base/io.jl
1	82.91	-0.13%	base/stream.jl
1	80.66	-0.21%	stdlib/FileWatching/src/FileWatching.jl
1	93.98	2.44%	stdlib/LinearAlgebra/src/diagonal.jl
2	83.92	-0.32%	base/compiler/typeinfer.jl
2	91.67	-1.85%	base/div.jl
2	91.92	-0.67%	base/iobuffer.jl
2	86.38	-0.94%	base/iostream.jl
2	93.54	-0.21%	base/math.jl
2	48.46	-4.09%	base/timing.jl
3	61.72	-2.34%	base/Base.jl
3	67.57	-1.4%	base/c.jl
3	82.14	-5.36%	base/hashing.jl
4	92.08	-0.41%	stdlib/Serialization/src/Serialization.jl
6	94.06	-5.94%	base/secretbuffer.jl
6	77.16	-3.05%	base/stacktraces.jl
7	44.87	-1.55%	base/util.jl
8	21.43	-57.14%	base/docs/core.jl
8	64.0	-32.0%	base/docs/utils.jl
10	87.34	-2.07%	base/float.jl
15	80.37	-4.67%	stdlib/LibGit2/src/LibGit2.jl
20	81.25	-7.35%	stdlib/LibGit2/src/types.jl
26	77.31	-21.85%	stdlib/LibGit2/src/remote.jl
36	57.14	-39.56%	stdlib/Logging/src/ConsoleLogger.jl
44	3.7	-81.48%	stdlib/Profile/src/Allocs.jl
46	23.89	-18.62%	stdlib/LibGit2/src/callbacks.jl
48	44.64	-42.86%	stdlib/Mmap/src/Mmap.jl
57	54.73	-23.81%	base/docs/Docs.jl
60	78.75	-10.73%	stdlib/REPL/src/docview.jl
87	73.1	-15.4%	base/gmp.jl
187	69.62	-28.13%	base/sort.jl
600	3.13	-85.53%	stdlib/Profile/src/Profile.jl

Jobs

ID	Job ID	Ran	Files	Coverage
1	#37659.1	22 Oct 2023 01:27PM UTC	339	86.18

JuliaLang / julia / #37659
77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #37659

JuliaLang / julia / #37659 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #37659

JuliaLang / julia / #37659
77%

README BADGES
x