Ouranosinc / xclim / 6042544311 / 2
90%
main: 92%

LAST BUILD BRANCH: more-spei-dists
DEFAULT BRANCH: main
Ran
Files 70
Run time 4s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 86.283% (+0.01%) from 86.273%
6042544311.2

push

github

web-flow 
Refactor base indicator classes (#1446)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #1263
- [ ] Tests for the changes have been added (for bug fixes / features)
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGES.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

Move around some of the base indicator classes code. Split the missing
values handling from the resampling handling. This way, indicators like
`return_level` can reduce the full time axis and still perform some
missing values handling.

### Does this PR introduce a breaking change?
No, not yet.


### Other information:
@huard @RondeauG, if I am not mistaken, `return_level` and `fit`
currently have missing values handling disabled because it was
impossible with the previous classes to have both this and full
reduction of "time". Now that it is possible, should we activate it ?

Similarly, `stats` had the "Any" missing method forced. Is there a
reason for that ? Here, I removed the argument, meaning it will use
"from_context".

7938 of 9200 relevant lines covered (86.28%)

2.57 hits per line

Source Files on job run-{{ matrix.tox-env }} - 6042544311.2