Ouranosinc / xclim / 6042544311

90%

main: 92%

Build Type

push

github

Committed by web-flow

Commit Message

Refactor base indicator classes (#1446)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #1263
- [ ] Tests for the changes have been added (for bug fixes / features)
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGES.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

Move around some of the base indicator classes code. Split the missing
values handling from the resampling handling. This way, indicators like
`return_level` can reduce the full time axis and still perform some
missing values handling.

### Does this PR introduce a breaking change?
No, not yet.


### Other information:
@huard @RondeauG, if I am not mistaken, `return_level` and `fit`
currently have missing values handling disabled because it was
impossible with the previous classes to have both this and full
reduction of "time". Now that it is possible, should we activate it ?

Similarly, `stats` had the "Any" missing method forced. Is there a
reason for that ? Here, I removed the argument, meaning it will use
"from_context".

Run Details

45 of 48 new or added lines in 4 files covered. (93.75%)

1 existing line in 1 file now uncovered.

8342 of 9200 relevant lines covered (90.67%)

3.48 hits per line