|
Repo Added
|
Files
34
|
Badge
README BADGES
|
push
github
XSI-2128: Ignore RBAC when destroying internal tasks (backport) (#6893) When calling `VDI.copy` or `VDI.pool_migrate` with `vm_power_admin` role, xapi may forward the operation to a remote host. In this case, xapi creates a pool session on the remote host and create a new task. When the operation completes, `try_internal_async` uses the user's session to destroy the task that was created by an internal pool session, but the user doesn't have the permission to destory other user's task (task.destroy/any), so it fails. Solution: This is an internal cleanup operation, so it doesn't need user RBAC restriction and checking. Ignore RBAC when destroying internal tasks by calling Db_actions.DB_Action.Task.destroy directly. Backport the [PR](https://github.com/xapi-project/xen-api/pull/6885) (cherry picked from commit [57adc22](https://github.com/xapi-project/xen-api/commit/57adc227f))
3504 of 4355 relevant lines covered (80.46%)
0.8 hits per line
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|
| Builds | Branch | Commit | Type | Ran | Committer | Via | Coverage |
|---|---|---|---|---|---|---|---|
| 21752735235 | v26.1.2 | XSI-2128: Ignore RBAC when destroying internal tasks (backport) (#6893) When calling `VDI.copy` or `VDI.pool_migrate` with `vm_power_admin` role, xapi may forward the operation to a remote host. In this case, xapi creates a pool session on the re... | push | github |
80.46 |