xapi-project / xen-api
80%
master: 80%

LAST BUILD BRANCH: private/gangj/CA-384228
DEFAULT BRANCH: master
Repo Added
Files 34
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH v26.0.0
branch: v26.0.0
CHANGE BRANCH
x

coverage: 80.459%. Remained the same
20823275909

push

github

web-flow 
CA-422187: fix NUMA on XS8 (#6824)

On XS8 we always raise an exception when attempting to claim from a
single node.
We wanted to only use soft affinity when the single node claim succeeded
(which is the correct fix on XS9, where this API is available). However
this meant that we've effectively completely disabled NUMA support on
XS8, without any way to turn it on.

Always use soft affinity when the single-node claim API is unavailable,
this should keep NUMA working on XS8.

On XS9 Xen itself would never raise ENOSYS (it has a `err = errno = 0`
on ENOSYS).

Fixes: fb66dfc03 ("CA-421847: set vcpu affinity if node claim
succeeded")

----
tested with:
* job 4526247 XS8: numaEnabledSerialStart on build
toolstack-ci-watch/289611 containing fb66dfc: fails as expected
* job 4526243 XS8: numaEnabledSerialStart on build ca-422187/289733
containing 677c539: succeeds as expected:
```(XEN) [  868.165385] 'u' pressed -> dumping numa info (now = 868165350914)
(XEN) [  868.165388] NODE0 start->0 size->17301504 free->1491212
(XEN) [  868.165391] NODE1 start->17301504 size->16777216 free->1238913
(XEN) [  868.165393] CPU0...39 -> NODE0
(XEN) [  868.165395] CPU40...79 -> NODE1
(XEN) [  868.165396] Memory location of each domain:
(XEN) [  868.165400] Domain 0 (total: 1933312):
(XEN) [  868.173626]     Node 0: 872292
(XEN) [  868.173627]     Node 1: 1061020
(XEN) [  868.173633] Domain 7 (total: 14068987):
(XEN) [  868.232568]     Node 0: 14068987
(XEN) [  868.232569]     Node 1: 0
(XEN) [  868.232573] Domain 8 (total: 14068987):
(XEN) [  868.291207]     Node 0: 0
(XEN) [  868.291208]     Node 1: 14068987
```

3504 of 4355 relevant lines covered (80.46%)

0.8 hits per line

Relevant lines Covered
4355 RELEVANT LINES 3504 COVERED LINES
0.8 HITS PER LINE
Source Files on v26.0.0

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
20823275909 v26.0.0 CA-422187: fix NUMA on XS8 (#6824) On XS8 we always raise an exception when attempting to claim from a single node. We wanted to only use soft affinity when the single node claim succeeded (which is the correct fix on XS9, where this API is avail... push web-flow github
80.46
See All Builds (6852)