xapi-project
/
xen-api
/
21752735235
80%
master: 80%
master: 80%
|
Ran
|
Jobs
1
|
Files
34
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 80.459%. Remained the same
push
github
web-flowXSI-2128: Ignore RBAC when destroying internal tasks (backport) (#6893) When calling `VDI.copy` or `VDI.pool_migrate` with `vm_power_admin` role, xapi may forward the operation to a remote host. In this case, xapi creates a pool session on the remote host and create a new task. When the operation completes, `try_internal_async` uses the user's session to destroy the task that was created by an internal pool session, but the user doesn't have the permission to destory other user's task (task.destroy/any), so it fails. Solution: This is an internal cleanup operation, so it doesn't need user RBAC restriction and checking. Ignore RBAC when destroying internal tasks by calling Db_actions.DB_Action.Task.destroy directly. Backport the [PR](https://github.com/xapi-project/xen-api/pull/6885) (cherry picked from commit [57adc22](https://github.com/xapi-project/xen-api/commit/57adc227f))
3504 of 4355 relevant lines covered (80.46%)
0.8 hits per line
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | python3.11 - 21752735235.1 | 34 |
80.46 |
GitHub Action Run |
