xapi-project / xen-api
80%
master: 80%

LAST BUILD BRANCH: v25.32.0
DEFAULT BRANCH: master
Repo Added
Files 34
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH v25.32.0
branch: v25.32.0
CHANGE BRANCH
x

coverage: 80.368%. Remained the same
18134138091

push

github

web-flow 
`idl/gen_client`: Don't specify argument values when they're equal to defaults (#6693)

https://github.com/xapi-project/xen-api/pull/6652 added a new parameter
to `Host.disable`. Since the method is used during an RPU, when a new
client calls an older server unaware of the parameter, this broke it.
Add a test reproducing what happens during an RPU and fix the issue in
`client.ml`.

---

Adds an older `server.ml` and `client.ml` from xapi 25.30.0 (with
`server.ml`
modified to compile after the XSA-474 interface changes), before
`Host.disable`
gained the `auto_enable` parameter.

Adds compatibility tests verifying that an older client can talk to a
newer
server and the other way around.

Before the fix, both `test_compatibility_with_old_server_*` fail,
showing that
`auto_enable` in `Host.disable` is an unexpected parameter. This failure
is
triggered on RPUs, when a newer xapi talks to an older one:

[exception] Server_error(MESSAGE_PARAMETER_COUNT_MISMATCH, [
host.disable; 1; 2 ])

So allow `client.ml` to skip specifying an arbitrary number of rightmost
arguments if they're all equal to their default values (since arguments
are
positional, once an argument is not skipped, no arguments to its left
can be
skipped).

Generated code for `host.disable` looks like the following:

```
let session_id = rpc_of_ref_session session_id in
let host = rpc_of_ref_host host in
let auto_enable = rpc_of_bool auto_enable in

let needed_args, _ = List.fold_right2
 (fun param default (acc, skipped)->
   (* Since arguments are positional, we can only skip specifying an
      argument that's equal to its default value if all the arguments to
      its right were also not specified *)
   if skipped then
     (match default with
     | Some default_value when param = default_value -> (acc, true)
     | _ -> (param::acc, false))
   else
     (param :: acc, false)
 ) [ session_id; host; auto_enable ] [ None; None; Some (Rpc.Bool true) ] ([], true)
in

rpc_wrapper rpc "host.disabl... (continued)

3496 of 4350 relevant lines covered (80.37%)

0.8 hits per line

Relevant lines Covered
4350 RELEVANT LINES 3496 COVERED LINES
0.8 HITS PER LINE
Source Files on v25.32.0

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
18134138091 v25.32.0 `idl/gen_client`: Don't specify argument values when they're equal to defaults (#6693) https://github.com/xapi-project/xen-api/pull/6652 added a new parameter to `Host.disable`. Since the method is used during an RPU, when a new client calls an o... push web-flow github
80.37
See All Builds (6073)