uber / cadence
57%
master: 72%

LAST BUILD BRANCH: fixit
DEFAULT BRANCH: master
Repo Added
Files 727
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH 1.1.x
branch: 1.1.x
CHANGE BRANCH
x

coverage: 57.245% (-0.04%) from 57.287%
0188b6e7-5a7f-4d55-a30e-f01c679ced89

push

buildkite

davidporter-id-au 
Bugfix/isolation groups domain drains (#5315)

What changed?
Fixes several bugs in the domain isolation-group handling which wasn't tested properly in replication it notably:

Fixes the problem of upserting configuration from the inactive region, which was previously would error
Fixes the problem of replication of configuration, which was entirely not working
Refactors the domain controller by splitting out this functionality into its own, much simpler function rather than continuing to overload the already incomprehensible domain controller.
Why?

How did you test it?

cadence --env docstore-prod11 --proxy_region dca admin isolation-groups get-domain --domain cadence-canary-global
Isolation Groups State
asdf5            Drained
asfd             Drained
-------------------------------------------------------------------------------------------------------------------------------------------------------------
~ » cadence --env an-env --proxy_region dca admin isolation-groups update-domain --domain cadence-canary-global  --remove-all-drains
-------------------------------------------------------------------------------------------------------------------------------------------------------------
~ » cadence --env an-env --proxy_region dca admin isolation-groups get-domain --domain cadence-canary-global
-- No groups found --
-------------------------------------------------------------------------------------------------------------------------------------------------------------
~ » cadence --env an-env --proxy_region phx admin isolation-groups get-domain --domain cadence-canary-global
-- No groups found --
Potential risks

87017 of 152008 relevant lines covered (57.25%)

2466.45 hits per line

Relevant lines Covered
152008 RELEVANT LINES 87017 COVERED LINES
2466.45 HITS PER LINE
Source Files on 1.1.x

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
0188b6e7... 1.1.x Bugfix/isolation groups domain drains (#5315) What changed? Fixes several bugs in the domain isolation-group handling which wasn't tested properly in replication it notably: Fixes the problem of upserting configuration from the inactive regio... push davidporter-id-au buildkite
57.25
01889da0... 1.1.x Change default value of AsyncTaskDispatchTimeout (#5320) push Shaddoll buildkite
57.29
018891cd... 1.1.x Seperate token pools for tasklists with isolation (#5314) push Shaddoll buildkite
57.26
01887d35... 1.1.x Increase number of forward tokens for isolation tasklists (#5310) push davidporter-id-au buildkite
57.27
01887cb8... 1.1.x Fix SearchAfter usage (#5311) push davidporter-id-au buildkite
57.26
01886f48... 1.1.x Minor fixes for sticky tasklist isolation (#5308) push Shaddoll buildkite
57.26
01886dc9... 1.1.x Adds some more coverage to isolation-group state handler (#5304) push davidporter-id-au buildkite
57.28
018859da... 1.1.x Feature/isolation group library logging improvements (#5295) Adds debug logs to the partitioner Adds metric counters around isolation group selection based on their being either healthy, missing pollers or drained includes some minor refactorin... push davidporter-id-au buildkite
57.23
01884a09... 1.1.x Update ClusterNameForFailoverVersion to return error (#5293) push David Porter buildkite
57.26
See All Builds (12090)