uber / cadence
63%
master: 72%

LAST BUILD BRANCH: fixit
DEFAULT BRANCH: master
Repo Added
Files 727
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH v1.2.7
branch: v1.2.7
CHANGE BRANCH
x

coverage: 62.64% (-0.02%) from 62.662%
018d8f3c-d989-4284-bc5e-6eb6797f6ff4

push

buildkite

web-flow 
Submodules step 2/2: draw the rest of the owl (#5609)

# What

Step 1 was in PR #5597

This second commit essentially:
1. splits the gcloud-only dependencies into a submodule which imports the main `github.com/uber/cadence` module, and not the reverse
2. also splits the "main" server build (`cmd/server`) into a submodule which imports the gcloud plugin and the main module (so that binary is unchanged)
3. removes `cloud.google.com/*` dependencies from the main `go.mod` (requires both 1 and 2)
4. adjusts things to work like they did before

Ultimately reducing our "main" (truly required) dependencies, while not making major changes to using or developing Cadence.

# Why

Part on principle, and part due to internal version conflicts.

In principle, "plugins" are "optional" and we should not be forcing _all_ optional dependencies on _all_ users of _any_ of Cadence.  
Splitting dependencies into choose-your-own-adventure submodules is simply good library design for the ecosystem, and it's something we should be doing more of.

In practice, this is essentially being forced because the gcloud archiver plugin pulls in some `cloud.google.com/*` stuff, which we upgraded, which forces breaking `google.golang.org/genproto` upgrades, which conflicts with other things in our internal monorepo.  
Removing this requirement (we do not use the gcloud archiver internally) allows us to continue using these incompatible libraries elsewhere, unblocking us while we wait for them to upgrade.  
This may also be true for [waves in the direction of The Internet] all of You, so rejoice!  Our pain is your gain.  We now no longer force you to use these libraries.

We will likely be doing this with more submodules in the future, this is just the first proof-of-concept and establishes a pattern to follow for the others.  
The client library will very likely also be doing this (or possibly in other repos) to separate out some of its more problematic dependenci... (continued)

91804 of 146558 relevant lines covered (62.64%)

2311.54 hits per line

Relevant lines Covered
146558 RELEVANT LINES 91804 COVERED LINES
2311.54 HITS PER LINE
Source Files on v1.2.7

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
018d8f3c... v1.2.7 Submodules step 2/2: draw the rest of the owl (#5609) # What Step 1 was in PR #5597 This second commit essentially: 1. splits the gcloud-only dependencies into a submodule which imports the main `github.com/uber/cadence` module, and not th... push web-flow buildkite
62.64
See All Builds (12090)