uber / cadence / 0188b6e7-5a7f-4d55-a30e-f01c679ced89
57%
master: 72%

LAST BUILD BRANCH: fixit
DEFAULT BRANCH: master
Ran
Jobs 1
Files 657
Run time 10s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 57.245% (-0.04%) from 57.287%
0188b6e7-5a7f-4d55-a30e-f01c679ced89

push

buildkite

davidporter-id-au 
Bugfix/isolation groups domain drains (#5315)

What changed?
Fixes several bugs in the domain isolation-group handling which wasn't tested properly in replication it notably:

Fixes the problem of upserting configuration from the inactive region, which was previously would error
Fixes the problem of replication of configuration, which was entirely not working
Refactors the domain controller by splitting out this functionality into its own, much simpler function rather than continuing to overload the already incomprehensible domain controller.
Why?

How did you test it?

cadence --env docstore-prod11 --proxy_region dca admin isolation-groups get-domain --domain cadence-canary-global
Isolation Groups State
asdf5            Drained
asfd             Drained
-------------------------------------------------------------------------------------------------------------------------------------------------------------
~ » cadence --env an-env --proxy_region dca admin isolation-groups update-domain --domain cadence-canary-global  --remove-all-drains
-------------------------------------------------------------------------------------------------------------------------------------------------------------
~ » cadence --env an-env --proxy_region dca admin isolation-groups get-domain --domain cadence-canary-global
-- No groups found --
-------------------------------------------------------------------------------------------------------------------------------------------------------------
~ » cadence --env an-env --proxy_region phx admin isolation-groups get-domain --domain cadence-canary-global
-- No groups found --
Potential risks

87017 of 152008 relevant lines covered (57.25%)

2466.45 hits per line

Jobs
ID Job ID Ran Files Coverage
1 0188b6e7-5a7f-4d55-a30e-f01c679ced89.1 657
57.25
Source Files on build 0188b6e7-5a7f-4d55-a30e-f01c679ced89