uber / cadence
63%
master: 72%

LAST BUILD BRANCH: fixit
DEFAULT BRANCH: master
Repo Added
Files 727
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH v1.2.7-prerelease4
branch: v1.2.7-prerelease4
CHANGE BRANCH
x

coverage: 62.698% (-0.04%) from 62.739%
018d5c75-27de-4ca1-9f12-b48f37fcf801

push

buildkite

web-flow 
Catch unit test failures in `make test` (#5635)

Surprisingly, this has not worked since tests were introduced to the makefile _in 2017_.
We've apparently been relying on CI's grepping for go test failure lines or something.

Rather trivially, without `-o pipefail` this only returns error messages from `tee`:
```bash
> false | tee -a file.log
> echo $?
0
```
Which means this also does not return `exit 1`:
```bash
for ... do
  go test whatever | tee -a file.log;
done
```
Which means you can fail a test and the tests keep going, and it exits 0:
```bash
> make test
...
FAIL	github.com/uber/cadence/common/util	0.245s
FAIL
ok  	github.com/uber/cadence/common/locks	0.252s	coverage: 93.3% of statements
...

> echo $?
0
```
Which kinda stinks for local development.  Failing tests can be hard to spot in the massive output of `V=1`, or dozens of lines off-screen if a lot of successful packages ran afterward.

Now this will continue running tests, but will clearly fail with a list of all failed packages:
```bash
> make test
...
FAIL    github.com/uber/cadence/common/util     0.245s
FAIL
ok      github.com/uber/cadence/common/locks    0.252s  coverage: 93.3% of statements
...
Failed packages:  ./common/util
make: *** [test] Error 1

> echo $?
1
```
Which is roughly how `go test ./...` works: it fails but keeps going, and does an `exit 1` if there were failures along the way (though it does not show the list of packages).

---

This also removes `bins` as a prerequisite for tests, as:
- it's slow and usually not necessary
- we now have `make build` which is MUCH more complete
- CI does this explicitly anyway, no need to do it more than once.

92246 of 147128 relevant lines covered (62.7%)

2283.91 hits per line

Relevant lines Covered
147128 RELEVANT LINES 92246 COVERED LINES
2283.91 HITS PER LINE
Source Files on v1.2.7-prerelease4

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
018d5c75... v1.2.7-prerelease4 Catch unit test failures in `make test` (#5635) Surprisingly, this has not worked since tests were introduced to the makefile _in 2017_. We've apparently been relying on CI's grepping for go test failure lines or something. Rather trivially, ... push web-flow buildkite
62.7
See All Builds (12090)