thoughtspot / visual-embed-sdk

96%

main: 96%

LAST BUILD ON BRANCH SCAL-338563

branch: SCAL-338563

CHANGE BRANCH

x

Reset

• SCAL-338563
• 970ActionParam
• Release-1.29.0
• SCAL-116040
• SCAL-116862
• SCAL-171534
• SCAL-175350
• SCAL-178305
• SCAL-183676-logout-pushkar
• SCAL-190699-SCAL-197688
• SCAL-193101
• SCAL-197688-SCAL-190699-sage-embed
• SCAL-199988
• SCAL-201087
• SCAL-202237
• SCAL-202996
• SCAL-204352
• SCAL-204765
• SCAL-204862
• SCAL-205873
• SCAL-205893
• SCAL-209159
• SCAL-209159-l
• SCAL-209441
• SCAL-209937
• SCAL-214843
• SCAL-214845
• SCAL-215582
• SCAL-218168
• SCAL-218894-sage-split-fullAppEmbed
• SCAL-221690
• SCAL-222310
• SCAL-222364
• SCAL-223643
• SCAL-226935
• SCAL-227728
• SCAL-227749
• SCAL-228730
• SCAL-230365
• SCAL-232534
• SCAL-233454-exp
• SCAL-233969--optimise-info-call
• SCAL-233969--optimise-info-call--v2
• SCAL-236431
• SCAL-237517
• SCAL-237838
• SCAL-237954
• SCAL-239365
• SCAL-239528
• SCAL-241849
• SCAL-244072
• SCAL-245513
• SCAL-246312
• SCAL-249159
• SCAL-251746
• SCAL-252103
• SCAL-252995
• SCAL-253886
• SCAL-255099
• SCAL-256749
• SCAL-256912
• SCAL-258312
• SCAL-258456--org-switcher--info-cache-fix
• SCAL-259706-payload
• SCAL-262299
• SCAL-262671
• SCAL-262923
• SCAL-263562
• SCAL-265064
• SCAL-265458_vivek
• SCAL-265809
• SCAL-266892
• SCAL-268538
• SCAL-269016
• SCAL-269747
• SCAL-270176
• SCAL-273450
• SCAL-274111
• SCAL-276944
• SCAL-279300
• SCAL-281665-css-var
• SCAL-284088
• SCAL-284563-fix
• SCAL-284763
• SCAL-286360-flag
• SCAL-286757-2
• SCAL-286984
• SCAL-287502
• SCAL-287664
• SCAL-287671
• SCAL-288229
• SCAL-288254
• SCAL-288528
• SCAL-288626
• SCAL-289371
• SCAL-290216-1
• SCAL-290924
• SCAL-291671
• SCAL-291789
• SCAL-295746
• SCAL-298120
• SCAL-299515
• SCAL-302303
• SCAL-302340
• SCAL-303326
• SCAL-303837--enablePbVizDataCaching-flag-support
• SCAL-306867
• SCAL-307028
• SCAL-311824
• SCAL-313306-embedParams-declarative
• SCAL-313693
• SCAL-314421
• SCAL-314423
• SCAL-315058
• SCAL-320861
• SCAL-321279
• SCAL-323226
• SCAL-324803
• SCAL-325540-embed-events
• SCAL-325540-events
• SCAL-326328
• SCAL-332974
• SCAL-333385
• SCAL-334772
• SCAL-336112
• SCAL-337466
• SCAL-337860
• SCAL-340056
• addFilter
• aditya
• ask-sage-embed-fix
• ask-sage-tse
• cbca
• cbca-2
• cbcafix
• chatdata
• chore/audit-fix-safe
• enable-data-panel-v2-by-default
• excludeRuntimeFilApp
• feat/scal-307017-prerender-fullheight
• feature-control-log
• fixsql
• fullheightV2
• he-fix
• host-events2
• jstnm
• jstnm-fix
• leak
• main
• main-mourya
• mcp
• minor-v-1-40-1
• param-override
• param-override-extend
• param-override-new
• parameter-override
• pre
• preRenderApproach2-Component-2
• prerender-bug
• primaryActions
• release
• reload
• remove-alert
• snyk-fix-fd7496974fdf674aac88226f1704f1e3
• spaces-in-queries
• spotter-embed
• sqlsql
• token-caching-validation
• token-coo
• tokenFail
• ui-passthrough-event
• version-bump-1.33.4
• version-bump-1.43.1
• versionup
• viewConfigChanges
• visibleEmbedCoordinatesFix
• vizHeight
• window-undefined

Build # #7982

Build Type

Pull #684

Committed by sastaachar

Commit Message

test: drop the rAF helper and a test that can no longer fail

flushAnimationFrame was there for the coalescer that is gone; syncs are
synchronous again. The hidden-frame test asserted syncPreRenderStyle is not
called on a scroll event, which now passes whether the frame is hidden or shown
because nothing listens for scroll — replaced with the contract that does exist,
that hiding releases the placeholder observer.

SCAL-338563

Pull Request Pull Request #684: SCAL-338563 Place the pre-rendered frame in the host's scrolling ancestor

Coverage Stats

2552 of 2761 branches covered (92.43%)

Branch coverage included in aggregate %.

31 of 32 new or added lines in 2 files covered. (96.88%)

1 existing line in 1 file now uncovered.

4247 of 4312 relevant lines covered (98.49%)

254.15 hits per line