thoughtspot / visual-embed-sdk / #7982

96%

main: 96%

Build Type

Pull #684

Committed by sastaachar

Commit Message

test: drop the rAF helper and a test that can no longer fail

flushAnimationFrame was there for the coalescer that is gone; syncs are
synchronous again. The hidden-frame test asserted syncPreRenderStyle is not
called on a scroll event, which now passes whether the frame is hidden or shown
because nothing listens for scroll — replaced with the contract that does exist,
that hiding releases the placeholder observer.

SCAL-338563

Pull Request Pull Request #684: SCAL-338563 Place the pre-rendered frame in the host's scrolling ancestor

Coverage Stats

2552 of 2761 branches covered (92.43%)

Branch coverage included in aggregate %.

31 of 32 new or added lines in 2 files covered. (96.88%)

1 existing line in 1 file now uncovered.

4247 of 4312 relevant lines covered (98.49%)

254.15 hits per line