thoughtspot / visual-embed-sdk
94%
main: 94%

LAST BUILD BRANCH: pre
DEFAULT BRANCH: main
Repo Added
Files 51
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH SCAL-313306-embedParams-declarative
branch: SCAL-313306-embedParams-declarative
CHANGE BRANCH
x

coverage: 94.224% (-0.09%) from 94.313%
#3956

Pull #547

yinstardev 
SCAL-313306: refactor declarative embedParams building in V1Embed

Replace imperative embedParams construction with declarative pattern to eliminate
mutation chains and improve maintainability. Each embed type now declares
contributions separately, merged once in base class.

Changes:
- Create new embedParams-builder.ts with EmbedParamsContribution interface
- Add getEmbedParamsContributions() method to TsEmbed (returns empty by default)
- Update getDefaultAppInitData() to collect and merge contributions declaratively
- Refactor AppEmbed: replaces getAppInitData() with getEmbedParamsContributions()
- Refactor LiveboardEmbed: replaces getAppInitData() with getEmbedParamsContributions()
- Refactor SearchEmbed: adds getEmbedParamsContributions(), preserves searchOptions in getAppInitData()
- Refactor SpotterEmbed: replaces getAppInitData() with getEmbedParamsContributions()
- Add contribution builders to spotter-utils and spotter-viz-utils
- Keep old builder functions for backward compatibility

Benefits:
- Eliminates spread operator chains causing hidden mutations
- Type-safe embedParams with explicit interface
- Easier to test contributions in isolation
- Cleaner code with single responsibility
- Maintains 100% backward compatibility

Tests: all 1103 tests pass
Pull Request #547: SCAL-313306: refactor declarative embedParams building in V1Embed

2084 of 2337 branches covered (89.17%)

Branch coverage included in aggregate %.

36 of 37 new or added lines in 6 files covered. (97.3%)

54 existing lines in 3 files now uncovered.

3805 of 3913 relevant lines covered (97.24%)

140.98 hits per line

Relevant lines Covered
3913 RELEVANT LINES 3805 COVERED LINES
140.98 HITS PER LINE
Source Files on SCAL-313306-embedParams-declarative

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
#3956 SCAL-313306-embedParams-declarative SCAL-313306: refactor declarative embedParams building in V1Embed Replace imperative embedParams construction with declarative pattern to eliminate mutation chains and improve maintainability. Each embed type now declares contributions separately... Pull #547 yinstardev
94.22
See All Builds (3993)