thoughtspot / visual-embed-sdk / #7975

96%

main: 96%

Build Type

Pull #684

Committed by sastaachar

Commit Message

SCAL-336321 Skip the pre-render home hop when a new embed shows an equal config

React constructs a new LiveboardEmbed on every mount, so the previous === this
check never matched and every remount of an unchanged pre-rendered liveboard
routed via home and reloaded. Compare viewConfig instead, treating callbacks
as equal.

SCAL-336321

Pull Request Pull Request #684: SCAL-338563 Place the pre-rendered frame in the host's scrolling ancestor

Coverage Stats

2551 of 2760 branches covered (92.43%)

Branch coverage included in aggregate %.

29 of 30 new or added lines in 2 files covered. (96.67%)

1 existing line in 1 file now uncovered.

4245 of 4310 relevant lines covered (98.49%)

253.97 hits per line