tamada / totebag
87%
main: 87%

LAST BUILD BRANCH: feature/notify-publish
DEFAULT BRANCH: main
Repo Added
Files 23
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH feature/notify-publish
branch: SELECT
CHANGE BRANCH
x

coverage: 86.654%. Remained the same
31591453398

push

github

tamada 
ci: make the release-published notification actually fire

notify-publish.yaml could not have worked as added, for two reasons.

The secret is named APP_CLIENT_ID in this repository, not CLIENT_ID, so
`create-github-app-token` was being handed an empty client id. The header
comment named a third spelling, APP_ID, and disagreed with itself two lines
later; it now matches what is actually registered.

More importantly the workflow would never have been triggered at all.
publish.yaml un-drafts the release with the automatic GITHUB_TOKEN, and the
Actions docs are explicit that "events triggered by the GITHUB_TOKEN will not
create a new workflow run" -- the recursion guard, whose only exceptions are
workflow_dispatch and repository_dispatch. So `release: published` never
reached any listener. finalize_release now publishes the release with the same
GitHub App instead.

That keeps the two files independent: publish.yaml gains no reference to
notify-publish.yaml, and notify-publish.yaml is still driven purely by the
release event. It also means a release published by hand notifies too.

The trade-off, inherent to keying off the release rather than the pipeline, is
that the notification fires even when a later step of publish.yaml failed --
v0.9.0 was exactly that case, with finalize_release green and publish_crate
red.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

2214 of 2555 relevant lines covered (86.65%)

12.97 hits per line

Relevant lines Covered
2555 RELEVANT LINES 2214 COVERED LINES
12.97 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
31591453398 feature/notify-publish ci: make the release-published notification actually fire notify-publish.yaml could not have worked as added, for two reasons. The secret is named APP_CLIENT_ID in this repository, not CLIENT_ID, so `create-github-app-token` was being handed an ... push tamada github
86.65
31577993154 main Merge pull request #93 from tamada/release/v0.9.0 Release v0.9.0: pure Rust dependencies and consistency cleanup push web-flow github
86.65
31577799877 release/v0.9.0 build: pin the toolchain with rust-toolchain.toml The three places that build totebag each used a different compiler: CI installed the latest stable, the cross-compile action hardcoded 1.88.0, and the developer's default was whatever rustup last ... Pull #93 tamada github
86.65
31571862620 release/v0.9.0 chore: publish the container image to quay.io/tama5/totebag Replaces ghcr.io/tamada/totebag. The Quay namespace (tama5) differs from the GitHub one (tamada), so the image name can no longer be derived from ${{ github.repository }}; it is now a jo... Pull #93 tamada github
86.65
31571656059 release/v0.9.0 fix: drop redundant borrows flagged by clippy 1.97 `useless_borrows_in_formatting` fires on the `&` in these two log arguments under the toolchain CI installs. The local toolchain here is 1.95, which does not flag them. Co-Authored-By: Claude Op... Pull #93 tamada github
86.65
31571370197 release/v0.9.0 fix: drop the no-op cargo update from the version bump Cargo.lock is gitignored, so `cargo update --workspace` only regenerated a file that git then discarded, at the cost of a full index download on every release. Co-Authored-By: Claude Opus 5 ... Pull #93 tamada github
86.62
31571255539 release/v0.9.0 feat: pure Rust dependencies, consistency cleanup for v0.9.0 Closes the whole v0.9.0 milestone (#73-#92). Dependencies are now pure Rust by default, so building needs no C toolchain and cross-compiling needs nothing but a Rust target: xz x... push tamada github
86.62
21331368028 main Merge pull request #72 from tamada/release/v0.8.16 feat: add crate publishing step to the release workflow with trusted … push web-flow github
84.11
21331362587 release/v0.8.16 feat: add crate publishing step to the release workflow with trusted publishing (tokenless publish) push tamada github
84.11
21331094085 main Merge pull request #71 from tamada/release/v0.8.15 Release/v0.8.15 push web-flow github
84.11
See All Builds (158)