stripe / stripe-ruby

96%

master: 97%

LAST BUILD ON BRANCH brandur-minor-stripe-client-cleanup

branch: brandur-minor-stripe-client-cleanup

CHANGE BRANCH

x

Reset

• brandur-minor-stripe-client-cleanup
• master
• ob-file-duck-typing
• v3.9.1
• brandur-configuration-ca-bundle-path
• jkakar/topup-client
• ob-skip-to-hash-for-nil
• v3.9.2
• ob-upgrade-stripe-mock
• jkakar/fix-product-issues
• v3.10.0
• ob-error-code
• v3.11.0
• brandur-only-empty-metadata
• ob-stripe-mock-0.11.0
• alexander/flexible-billing
• brandur-deleted-objects-with-ids
• v3.12.0
• brandur-initialize-instance-var
• v3.12.1
• brandur-stripe-mock-v0.12.0
• ob-irc-badge
• v3.13.0
• brandur-configuring-version
• brandur-stripe-mock-0-15
• fay/issfr
• brandur-merge-query-params
• v3.13.1
• fay/update-version
• v3.14.0
• brandur-frozen-strings
• v3.15.0
• brandur-fix-tests
• remi-add-payment-intent
• zwick_set_app_info_partner_updates
• v3.16.0
• v3.17.0
• brandur-ruby-25
• remi-move-payment-intent-stripe-mock
• ob-better-resource-url
• v3.17.1
• v3.17.2
• remi-add-issuing-resources
• v3.18.0
• remi-add-sigma-scheduled-query-run
• v3.19.0
• brandur-disable-lengths
• remi-scheduled-run-mock
• ob-file-link
• foresthu-add-topup-cancel-support
• v3.20.0
• ob-topup-cancel
• v3.21.0
• brandur-integer-indexes
• v3.22.0
• tomer-remove-edittable-bitcoin-receivers-actions
• remi-add-usage-record-summary
• v3.23.0
• ob-prep-file
• v3.24.0
• remi-fix-payment-intent
• v3.25.0
• brandur-minor-test-fixes
• brandur-stripe-mock-030
• remi-add-reporting-resources
• v3.26.0
• brandur-hash
• v3.26.1
• ob-file-resource
• daz-terminal-bindings
• v3.27.0
• v3.28.0
• remi-add-person
• remi-add-invoice-methods
• remi-add-webhook-endpoint
• v3.29.0
• v3.30.0
• remi-add-radar-lists
• akropp-add-client-telemetry
• v3.31.0
• akropp-telemetry-in-ms
• v3.31.1
• brandur-net-http-persistent
• brandur-ruby-20
• brandur-ruby-21
• v4.0.0
• brandur-check-request-id
• v4.0.1
• ob-bump-faraday
• v4.0.2
• ob-fix-windows
• v4.0.3
• metadata-api
• v4.1.0
• remi-add-radar-review
• v4.2.0
• remi-add-account-links
• v4.3.0
• ob-openapi-files
• remi-add-checkout-sessions
• v4.4.0
• v4.4.1
• brandur-support-express-authorize
• v4.5.0
• ob-fix-ci
• mickjermsurawong/update-stripe-mock-version
• ob-serialize-individual
• brandur-select-port
• v4.6.0
• brandur-port-in-output
• remi-fix-checkout-sessions
• v4.7.0
• remi-add-subscription-schedules
• brandur-fix-query-encoding
• v4.7.1
• brandur-simpler-encoding
• v4.8.0
• brandur-remove-file-encoding
• v4.8.1
• v4.9.0
• remi-add-payment-methods
• remi-fix-tests
• remi-add-terminal-delete
• brandur-warn-on-remove-error
• v4.9.1
• remi-add-checkout-session-retrieve
• v4.10.0
• ob-static-methods
• ob-proxy
• v4.11.0
• ob-dsl-custom-method
• v4.12.0
• ob-test-file-link-data
• remi-fix-tests-latest
• remi-add-credit-notes
• remi-add-creditnote
• remi-add-tax-rates
• remi-add-tax-ids
• remi-bring-nested-tests-up
• brandur-relax-file-constraints
• v4.13.0
• v4.14.0
• v4.15.0
• v4.16.0
• pavel/single-quotes
• pavel/simplify-inheritance
• remi-add-customer-balance-transactions
• rwz/sort-methods
• rwz/inline-paths
• pavel/more-inheritance
• pavel/more-method-sorting
• pavel/codegen
• pavel/normalize-opts
• remi-add-account-capabilities
• v4.17.0
• ob-vscode
• ob-early-fraud-warning
• ob-fix-tests
• ob-travis-ruby26
• v4.18.0
• ob-rubocop
• v4.18.1
• ralex/codegen
• ralex/codegen-2
• remi-fix-readme
• ob-decimal-string
• rattrayalex/codegen-f7fc004
• v4.19.0
• ob-enable-telemetry
• v4.20.0
• remi-setupintents
• v4.20.1
• v4.21.0
• ralex/fix-initialize-from
• ob-gem-metadata
• ralex/unified_requests
• v4.21.1
• v4.21.2
• brandur-net-http
• brandur-raise-argument-error
• v4.21.3
• ob-error-object
• integration-v5
• brandur-named-code
• brandur-drop-old-ruby
• ob-bump-rubocop
• ob-travis-bundler
• ob-remove-old-methods
• remi-fix-bt
• v4.22.0
• ob-remove-all
• ob-github-actions
• v4.22.1
• rattrayalex/codegen-c806fa1
• v4.23.0
• ob/codegen-c806fa1
• ob-remove-issuerfraudrecord
• brandur-expand-retries
• brandur-clearable-connections
• brandur-retry-fix
• brandur-remove-deprecated
• brandur-thread-state
• ob-upcoming-line-items
• ob/codegen-63fe31a
• v5.0.0
• brandur-keep-alive-to-30
• v5.0.1
• brandur-minor-refactor
• brandur-retry-lock-timeouts
• v5.1.0
• brandur-request-id-test
• v5.1.1
• brandur-assert-raises
• brandur-connection-manager-gc
• v5.2.0
• brandur-stripe-should-retry
• v5.3.0
• brandur-monotonic-time
• brandur-drop-timecop
• v5.4.0
• v5.4.1
• v5.5.0
• brandur-exclude-examples
• brandur-nicer-error
• v5.6.0
• brandur-backwards-auto-paging-each
• v5.7.0
• tmaxwell/fix-connect-base
• v5.7.1
• richardm-apiref-link
• remi-add-mandate
• v5.8.0
• v5.9.0
• ralex/list-urs-and-st
• v5.10.0
• richardm-junit-output
• rattrayalex-stripe-patch-1
• ob/codegen-ab6898a
• ob-creditnote-preview
• v5.11.0
• ob/codegen-ba4dcd0
• v5.12.0
• ob-oauth
• v5.12.1
• v5.13.0
• rubocop-0.79
• brandur-clean-test-output
• remi-wip-creditnote-line
• remi/codegen-d663cdb
• v5.14.0
• brandur-webmock-380
• remi-change-readme
• brandur-request-begin
• v5.15.0
• brandur-rubocop-080
• ob/codegen-40a20cd
• v5.16.0
• brandur-idempotent-replayed
• v5.17.0
• brandur-shoulda-context-2-0-0-rc4
• remi/codegen-824d494
• v5.18.0
• brandur-expose-compute-signature
• v5.19.0
• brandur-generate-header
• v5.20.0
• remi/codegen-f75fd88
• v5.21.0
• remi/codegen-72527e3
• v5.22.0
• ctrudeau-add-code-generated-comment-to-ruby
• brandur-rename-request
• remi/codegen-f71053e
• v5.23.0
• v5.23.1
• v5.24.0
• cjavilla/update-readme
• remi/codegen-474461f
• v5.25.0
• remi/codegen-3854362
• v5.26.0
• remi/codegen-4bd4c01
• v5.27.0
• v5.28.0
• richardm-generate-via-stripetype
• v5.29.0
• cjavilla/add-playlist-link-to-readme
• brandur-fix-delete-discount
• v5.29.1
• richardm-billingportalconfig
• latest-codegen
• v5.30.0
• richardm-gha
• HEAD
• anniel-test-coverage
• anniel-coveralls
• beta
• sdk-release/next-major

Build # 3386

Build Type

Pull #832

travis-ci

Committed by web-flow

Commit Message

Minor cleanup in `StripeClient`

I ended up having to relax the maximum method line length in a few
previous PRs, so I wanted to try one more cleanup pass in
`execute_request` to see if I could get it back at all.

The answer was "not by much" (without reducing clarity), but I found a
few places that could be tweaked. Unfortunately, ~50 lines is probably
the "right" length for this method in that you _could_ extract it
further, but you'd end up passing huge amounts of state all over the
place in method parameters, and it really wouldn't look that good.

Pull Request Pull Request #832: Minor cleanup in `StripeClient`

Run Details

11 of 11 new or added lines in 1 file covered. (100.0%)

1839 of 1915 relevant lines covered (96.03%)

2448.42 hits per line