stripe / stripe-ruby
96%
master: 97%

LAST BUILD BRANCH: HEAD
DEFAULT BRANCH: master
Repo Added
Files 262
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH brandur-connection-manager-gc
branch: brandur-connection-manager-gc
CHANGE BRANCH
x

3444

Pull #851

travis-ci

web-flow 
Introduce system for garbage collecting connection managers

Introduces a system for garbage collecting connection managers in an
attempt to solve #850.

Previously, the number of connection managers (and by extension the
number of connections that they were holding) would stay stable if a
program used a stable number of threads. However, if threads were used
disposably, the number of active connection managers out there could
continue to grow unchecked, and each of those could be holding one or
more dead connections which are no longer open, but still holding a file
descriptor waiting to be unlinked in disposed of by Ruby's GC.

This PR introduces a connection manager garbage collector that runs
periodically whenever a new connection manager is created. Connection
managers get a timestamp to indicate when they were last used, and the
GC runs through each one and prunes any that haven't seen use within a
certain threshold (currently, 120 seconds). This should have the effect
of removing connection managers as they're not needed anymore, and thus
resolving the socket leakage seen in #850.

I had to make a couple implementation tweaks to get this working
correctly. Namely:

* The `StripeClient` class now tracks thread contexts instead of
  connection managers. This is so that when we're disposing of a
  connection manager, we can set `default_connection_manager` on its
  parent thread context to `nil` so that it's not still tracking a
  connection manager that we're trying to get rid of.

* `StripeClient` instances can still be instantiated as before, but no
  longer internalize a reference to their own connection manager,
  instead falling back to the one in the current thread context. The
  rationale is that when trying to dispose of a connection manager, we'd
  also have to dispose of its reference in any outstanding
  `StripeClient` instances that might still be tracking it, and that
  starts to get a little unwieldy. I've left `#connection_manager`... (continued)
Pull Request #851: Introduce system for garbage collecting connection managers

53 of 53 new or added lines in 2 files covered. (100.0%)

7586 of 7894 relevant lines covered (96.1%)

2398.4 hits per line

Relevant lines Covered
7894 RELEVANT LINES 7586 COVERED LINES
2398.4 HITS PER LINE
Source Files on brandur-connection-manager-gc
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
3444 brandur-connection-manager-gc Introduce system for garbage collecting connection managers Introduces a system for garbage collecting connection managers in an attempt to solve #850. Previously, the number of connection managers (and by extension the number of connections tha... Pull #851 web-flow travis-ci pending completion  
3443 brandur-connection-manager-gc Introduce system for garbage collecting connection managers Introduces a system for garbage collecting connection managers in an attempt to solve #850. Previously, the number of connection managers (and by extension the number of connections tha... push brandur travis-ci pending completion  
3442 brandur-connection-manager-gc Introduce system for garbage collecting connection managers Introduces a system for garbage collecting connection managers in an attempt to solve #850. Previously, the number of connection managers (and by extension the number of connections tha... Pull #851 web-flow travis-ci pending completion  
3441 brandur-connection-manager-gc Introduce system for garbage collecting connection managers Introduces a system for garbage collecting connection managers in an attempt to solve #850. Previously, the number of connection managers (and by extension the number of connections tha... push brandur travis-ci pending completion  
3440 brandur-connection-manager-gc Introduce system for garbage collecting connection managers Introduces a system for garbage collecting connection managers in an attempt to solve #850. Previously, the number of connection managers (and by extension the number of connections tha... Pull #851 web-flow travis-ci pending completion  
3439 brandur-connection-manager-gc Introduce system for garbage collecting connection managers Introduces a system for garbage collecting connection managers in an attempt to solve #850. Previously, the number of connection managers (and by extension the number of connections tha... push brandur travis-ci pending completion  
3438 brandur-connection-manager-gc Introduce system for garbage collecting connection managers Introduces a system for garbage collecting connection managers in an attempt to solve #850. Previously, the number of connection managers (and by extension the number of connections tha... Pull #851 web-flow travis-ci pending completion  
3437 brandur-connection-manager-gc Introduce system for garbage collecting connection managers Introduces a system for garbage collecting connection managers in an attempt to solve #850. Previously, the number of connection managers (and by extension the number of connections tha... push brandur travis-ci pending completion  
See All Builds (4151)