• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

stripe / stripe-ruby / 3385
96%
master: 97%

Build:
Build:
LAST BUILD BRANCH: HEAD
DEFAULT BRANCH: master
Ran 19 Aug 2019 09:04PM UTC
Jobs 5
Files 97
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
3385

push

travis-ci

brandur
Minor cleanup in `StripeClient`

I ended up having to relax the maximum method line length in a few
previous PRs, so I wanted to try one more cleanup pass in
`execute_request` to see if I could get it back at all.

The answer was "not by much" (without reducing clarity), but I found a
few places that could be tweaked. Unfortunately, ~50 lines is probably
the "right" length for this method in that you _could_ extract it
further, but you'd end up passing huge amounts of state all over the
place in method parameters, and it really wouldn't look that good.

1839 of 1915 relevant lines covered (96.03%)

2448.42 hits per line

Jobs
ID Job ID Ran Files Coverage
1 3385.1 (2.3) 19 Aug 2019 09:04PM UTC 0
96.14
Travis Job 3385.1
2 3385.2 (2.4) 19 Aug 2019 09:04PM UTC 0
96.14
Travis Job 3385.2
3 3385.3 (2.5) 19 Aug 2019 09:04PM UTC 0
96.14
Travis Job 3385.3
4 3385.4 (2.6) 19 Aug 2019 09:04PM UTC 0
96.11
Travis Job 3385.4
5 3385.5 (jruby-9.2.7.0) 19 Aug 2019 09:07PM UTC 0
0.0
Travis Job 3385.5
Source Files on build 3385
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #3385
  • b372f8f4 on github
  • Prev Build on brandur-minor-stripe-client-cleanup (#3383)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc