stripe / stripe-ruby
95%
master: 97%

LAST BUILD BRANCH: HEAD
DEFAULT BRANCH: master
Repo Added
Files 262
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH brandur-net-http
branch: brandur-net-http
CHANGE BRANCH
x

3246

Pull #813

travis-ci

web-flow 
Convert library to use built-in `Net::HTTP`

Moves the library off of Faraday and over onto the standard library's
built-in `Net::HTTP` module. The upside of the transition is that we
break away from a few dependencies that have caused us a fair bit of
trouble in the past, the downside is that we need more of our own code
to do things (although surprisingly, not that much more).

The biggest new pieces are:

* `ConnectionManager`: A per-thread class that manages a connection to
  each Stripe infrastructure URL (like `api.stripe.com`,
  `connect.stripe.com`, etc.) so that we can reuse them between
  requests. It's also responsible for setting up and configuring new
  `Net::HTTP` connections, which is a little more heavyweight
  code-wise compared to other libraries. All of this could have lived in
  `StripeClient`, but I extracted it because that class has gotten so
  big.

* `MultipartEncoder`: A class that does multipart form encoding for file
  uploads. Unfortunately, Ruby doesn't bundle anything like this. I
  built this by referencing the Go implementation because the original
  RFC is not very detailed or well-written. I also made sure that it was
  behaving similarly to our other custom implementations like
  stripe-node, and that it can really upload a file outside the test
  suite.

There's some risk here in that it's easy to miss something across one of
these big transitions. I've tried to test out various error cases
through tests, but also by leaving scripts running as I terminate my
network connection and bring it back. That said, we'd certainly release
on a major version bump because some of the interface (like setting
`Stripe.default_client`) changes.
Pull Request #813: Convert library to use built-in `Net::HTTP`

156 of 156 new or added lines in 5 files covered. (100.0%)

1883 of 1979 relevant lines covered (95.15%)

3739.04 hits per line

Relevant lines Covered
1979 RELEVANT LINES 1883 COVERED LINES
3739.04 HITS PER LINE
Source Files on brandur-net-http

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
3246 brandur-net-http Convert library to use built-in `Net::HTTP` Moves the library off of Faraday and over onto the standard library's built-in `Net::HTTP` module. The upside of the transition is that we break away from a few dependencies that have caused us a fair b... Pull #813 web-flow travis-ci pending completion  
3245 brandur-net-http Convert library to use built-in `Net::HTTP` Moves the library off of Faraday and over onto the standard library's built-in `Net::HTTP` module. The upside of the transition is that we break away from a few dependencies that have caused us a fair b... push brandur travis-ci pending completion  
3242 brandur-net-http Convert library to use built-in `Net::HTTP` Moves the library off of Faraday and over onto the standard library's built-in `Net::HTTP` module. The upside of the transition is that we break away from a few dependencies that have caused us a fair b... Pull #813 web-flow travis-ci pending completion  
3243 brandur-net-http Convert library to use built-in `Net::HTTP` Moves the library off of Faraday and over onto the standard library's built-in `Net::HTTP` module. The upside of the transition is that we break away from a few dependencies that have caused us a fair b... push brandur travis-ci pending completion  
3239 brandur-net-http Convert library to use built-in `Net::HTTP` Moves the library off of Faraday and over onto the standard library's built-in `Net::HTTP` module. The upside of the transition is that we break away from a few dependencies that have caused us a fair b... Pull #813 web-flow travis-ci pending completion  
3238 brandur-net-http Convert library to use built-in `Net::HTTP` Moves the library off of Faraday and over onto the standard library's built-in `Net::HTTP` module. The upside of the transition is that we break away from a few dependencies that have caused us a fair b... push brandur travis-ci pending completion  
3237 brandur-net-http Convert library to use built-in `Net::HTTP` Moves the library off of Faraday and over onto the standard library's built-in `Net::HTTP` module. The upside of the transition is that we break away from a few dependencies that have caused us a fair b... Pull #813 web-flow travis-ci pending completion  
3236 brandur-net-http Convert library to use built-in `Net::HTTP` Moves the library off of Faraday and over onto the standard library's built-in `Net::HTTP` module. The upside of the transition is that we break away from a few dependencies that have caused us a fair b... push brandur travis-ci pending completion  
3235 brandur-net-http Convert library to use built-in `Net::HTTP` Moves the library off of Faraday and over onto the standard library's built-in `Net::HTTP` module. The upside of the transition is that we break away from a few dependencies that have caused us a fair b... Pull #813 web-flow travis-ci pending completion  
3234 brandur-net-http Convert library to use built-in `Net::HTTP` Moves the library off of Faraday and over onto the standard library's built-in `Net::HTTP` module. The upside of the transition is that we break away from a few dependencies that have caused us a fair b... push brandur travis-ci pending completion  
See All Builds (4151)