stores-com / bloodhound

86%

main: 88%

Pull #176

github

Throw a TypeError when track() is passed a callback

The 3.x signature was track(trackingNumber, [options,] callback), so
track(number, callback) was a supported form. Without a guard the
callback lands in the options slot: track() returns a promise nobody
holds, the callback never fires, and the caller waits forever. When the
carrier can be guessed it also makes the live carrier call and resolves
silently; when it can't, the unhandled rejection reads "Unknown
carrier." and points at the carrier rather than at the API change.

Throw instead, in both the options and the callback position, so the
failure names its own cause.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

313 of 374 branches covered (83.69%)

Branch coverage included in aggregate %.

45 of 45 new or added lines in 1 file covered. (100.0%)

1485 of 1706 relevant lines covered (87.05%)

16.62 hits per line