source-academy / stories-backend
47%

DEFAULT BRANCH: main
Repo Added
Token B6cpVuK5i1Jlgoy7Ohc7mUKBjl7jrfwHZ regen
Build 525 Last
Files 21
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 47.43% (-2.2%) from 49.653%
9050524776

push

github

web-flow 
Change /groups/{group id}/users route (#115)

* fix: inject user id into context in development env

* feat: add ID column to list view of Users

* feat: add role attribute to /groups/{groupId}/users response

a userId could have multiple roles, if it is present in the usergroups table in multiple rows
(with different groupId).

however, since we specify the groupId in the /group/{groupId}/users route, it makes sense that we
only retrieve users that have that groupId.

- in controller, get groupId from context
- for each user obtained from the users table, call GetUserRoleByID function from usergroups model
- store the roles obtained in an array
- pass array to updated ListFrom function from users view, which now include a role attribute
in its JSON response

* fix: DeleteUser in users model

previously, the DeleteUser function was not working as it chained
`.Delete(&user)` after `.First(&user)`. this resulted in a query as
shown, and its corresponding error:

* `ERROR: table name "users" specified more than once (SQLSTATE 42712)
[8.059ms] [rows:1] UPDATE "users" SET "deleted_at"='2024-02-12
20:52:41.02' FROM "users" WHERE id = 4 AND "users"."deleted_at" IS NULL
AND "users"."id" = 4`

the intent of `.First(&user)` was likely to store the user to be deleted
first in the `user` variable with the use of a `SELECT` SQL statement.
however, chaining another method at the end of a finisher method likely
led to some errors (see chaining
[here](https://gorm.io/docs/method_chaining.html)).

thus, this commit attempts to separate the two statements, preserving
the initial intent of storing the user to be deleted before deleting,
and then returning this user.

* feat: function to update row in users model

* feat: function to update row in usergroups model

* feat: add /users/{userID}/role put route

missing validation for parameters, but seemed unnecessary since there is
only one route with parameter validation (crea... (continued)

0 of 30 new or added lines in 3 files covered. (0.0%)

286 of 603 relevant lines covered (47.43%)

0.52 hits per line

Relevant lines Covered
603 RELEVANT LINES 286 COVERED LINES
0.52 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
9050524776 main Change /groups/{group id}/users route (#115) * fix: inject user id into context in development env * feat: add ID column to list view of Users * feat: add role attribute to /groups/{groupId}/users response a userId could have multiple ro... push web-flow github
47.43
9050394925 change-/groups/{groupId}/users-route Refactor logic Pull #115 RichDom2185 github
47.43
9050273125 change-/groups/{groupId}/users-route Use range iterator for users list view Pull #115 RichDom2185 github
47.04
8656226807 stories-moderation Run go mod tidy Pull #120 keyansheng github
47.69
8549834697 setup-nullable-types Merge branch 'main' into setup-nullable-types Pull #104 web-flow github
49.65
8445005361 stories-moderation Revert random added and deleted newlines and comments Pull #120 keyansheng github
47.69
8442450825 stories-moderation Fix migration name Pull #120 keyansheng github
47.69
8442415791 stories-moderation Fix migration ordering Pull #120 keyansheng github
47.69
8442349798 stories-moderation Fix TestCreateStory/can_create_without_group fail Pull #120 keyansheng github
47.69
8439610498 stories-moderation Fix migration ordering Pull #120 keyansheng github
45.32
See All Builds (507)